Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2529573002: Revert of [wasm] WebAssembly.Memory object can be referenced by multiple Instance objects. (Closed)

Created:
4 years ago by Michael Hablich
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] WebAssembly.Memory object can be referenced by multiple Instance objects. (patchset #13 id:240001 of https://codereview.chromium.org/2471883003/ ) Reason for revert: Test crashes after an unrelated revert: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/7189 Reverting because of recommendation from WASM team. Original issue's description: > [wasm] WebAssembly.Memory object can be referenced by multiple Instance objects. > > Add support for WebAssembly.Memory objects to be simultaneously referenced by multiple Instance objects. GrowingMemory should maintain a consistent view of memory across instances. > - Store a link to instances that share WebAssembly.Memory in the WasmMemoryObject, updated on instantiate. > - Implement WasmInstanceWrapper as a wrapper around the instance object to keep track of previous/next instances, instance object is stored as a WeakCell that can be garbage collected. > - MemoryInstanceFinalizer maintains a valid list of instances when an instance is garbage collected. > - Refactor GrowInstanceMemory to GrowMemoryBuffer that allocates a new buffer, and UncheckedUpdateInstanceMemory that updates memory references for an instance. > > R=titzer@chromium.org, mtrofin@chromium.org, bradnelson@chromium.org > > Committed: https://crrev.com/30ef8e33f3a199a27ca8512bcee314c9522d03f6 > Committed: https://crrev.com/3c98e339599b068f1ed630afb7601ff942424d31 > Cr-Original-Commit-Position: refs/heads/master@{#41121} > Cr-Commit-Position: refs/heads/master@{#41198} TBR=bradnelson@chromium.org,mtrofin@chromium.org,titzer@chromium.org,gdeepti@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/de330e13daf6e927474a149fce3b3819572385dd Cr-Commit-Position: refs/heads/master@{#41208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -539 lines) Patch
M src/runtime/runtime-wasm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-js.cc View 4 chunks +29 lines, -7 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/wasm/wasm-module.cc View 9 chunks +61 lines, -163 lines 0 comments Download
M src/wasm/wasm-objects.h View 5 chunks +3 lines, -63 lines 0 comments Download
M src/wasm/wasm-objects.cc View 5 chunks +5 lines, -57 lines 0 comments Download
M test/mjsunit/wasm/import-memory.js View 2 chunks +1 line, -138 lines 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 1 chunk +0 lines, -1 line 0 comments Download
D test/mjsunit/wasm/memory-instance-validation.js View 1 chunk +0 lines, -103 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Hablich
Created Revert of [wasm] WebAssembly.Memory object can be referenced by multiple Instance objects.
4 years ago (2016-11-23 09:08:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529573002/1
4 years ago (2016-11-23 09:08:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 09:08:31 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-23 09:08:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de330e13daf6e927474a149fce3b3819572385dd
Cr-Commit-Position: refs/heads/master@{#41208}

Powered by Google App Engine
This is Rietveld 408576698