MD Settings: indicate extension controlled search engines

chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action_menu.html">
 <link rel="import" href="chrome://resources/cr_elements/icons.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/html/icon.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
+<link rel="import" href="/controls/extension_controlled_indicator.html">
 <link rel="import" href="/search_engines_page/search_engine_dialog.html">
 <link rel="import" href="/search_engines_page/search_engine_entry_css.html">
 <link rel="import" href="/search_engines_page/search_engines_browser_proxy.html">
 <link rel="import" href="/settings_shared_css.html">
 
 <dom-module id="settings-search-engine-entry">
   <template>
     <style include="settings-shared search-engine-entry">
-      :host([is-default]) {
+      :host([is-default]) .list-item {
         font-weight: 500;
       }
 
       .name-column,
       .keyword-column {
         flex: 3;
       }
 
       .url-column {
         flex: 4;
         overflow: hidden;
         text-overflow: ellipsis;
         white-space: nowrap;
       }
+
+      :host(:not([show-dots_])) paper-icon-button {
+        pointer-events: none;
+        visibility: hidden;
+      }
     </style>
 
     <template is="dom-if" if="[[showEditSearchEngineDialog_]]" restamp>
       <settings-search-engine-dialog model="[[engine]]">
       </settings-search-engine-dialog>
     </template>
     <div class="list-item">
       <div class="name-column">
         <span class="favicon-image"
             style="background-image: [[getIconSet_(engine.iconURL)]]"></span>
         <span class="name">[[engine.displayName]]</span>
       </div>
       <div class="keyword-column">[[engine.keyword]]</div>
       <div class="url-column">[[engine.url]]</div>
       <paper-icon-button icon="cr:more-vert" tabindex$="[[tabindex]]"
           on-tap="onDotsTap_">
       </paper-icon-button>
-      <dialog is="cr-action-menu">
-        <button class="dropdown-item" role="option" on-tap="onMakeDefaultTap_"
-            hidden$="[[!engine.canBeDefault]]" id="makeDefault">
-          $i18n{searchEnginesMakeDefault}
-        </button>
-        <button class="dropdown-item" role="option" on-tap="onEditTap_"
-            hidden$="[[!engine.canBeEdited]]"
-            id="edit">$i18n{searchEnginesEdit}</button>
-        <button class="dropdown-item" role="option" on-tap="onDeleteTap_"
-            hidden$="[[!engine.canBeRemoved]]"
-            id="delete">$i18n{searchEnginesRemoveFromList}</button>
-      </dialog>
+      <template is="dom-if" if="[[showDots_]]">

[dpapad, 2016/11/23 19:59:54]

Perhaps add a test for this?

[Dan Beam, 2016/12/01 06:21:52]

well, I removed the dom-if for a few reasons.

a) an overwhelming majority of the time |showDots_| will be true so this is
arguably worse for performance than better.

b) it was breaking the tests because they rely this menu existing even when an
engine can't be made default, edited, nor removed.  this is also related to the
type errors (missing arguments) we found.

that said: do you want me to test that when an engine can't be edited, made
default, or removed, the entry's <paper-icon-button> is visibility: hidden;? 
because that's starting to sound kinda brittle.

+        <dialog is="cr-action-menu">
+          <button class="dropdown-item" role="option" on-tap="onMakeDefaultTap_"
+              hidden$="[[!engine.canBeDefault]]" id="makeDefault">
+            $i18n{searchEnginesMakeDefault}
+          </button>
+          <button class="dropdown-item" role="option" on-tap="onEditTap_"
+              hidden$="[[!engine.canBeEdited]]"
+              id="edit">$i18n{searchEnginesEdit}</button>
+          <button class="dropdown-item" role="option" on-tap="onDeleteTap_"
+              hidden$="[[!engine.canBeRemoved]]"
+              id="delete">$i18n{searchEnginesRemoveFromList}</button>
+        </dialog>
+      </template>
     </div>
+    <template is="dom-if" if="[[engine.extension]]">
+      <extension-controlled-indicator
+          extension-id="[[engine.extension.id]]"
+          extension-name="[[engine.extension.name]]"
+          extension-can-be-disabled="[[engine.extension.canBeDisabled]]">
+      </extension-controlled-indicator>
+    </template>
   </template>
   <script src="search_engine_entry.js"></script>
 </dom-module>