Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 2529533003: Pass DesktopEnvironmentOptions form network to desktop process. (Closed)

Created:
4 years ago by Sergey Ulanov
Modified:
4 years ago
Reviewers:
Robert Sesek, Hzj_jie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass DesktopEnvironmentOptions form network to desktop process. Now DesktopEnvironmentOptions are passed to the desktop process in StartSessionAgent IPC message. This will allow the network process controll DesktopEnvironment configuration and particularly DesktopCaptureOptions. Committed: https://crrev.com/c986f523c34dbaf0d943abae125094a72cc8c2f8 Cr-Commit-Position: refs/heads/master@{#434754}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -37 lines) Patch
M remoting/host/chromoting_messages.h View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/host/chromoting_param_traits.h View 2 chunks +11 lines, -0 lines 2 comments Download
M remoting/host/chromoting_param_traits.cc View 1 chunk +68 lines, -0 lines 0 comments Download
M remoting/host/desktop_process.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/desktop_process_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/desktop_session_agent.h View 3 chunks +2 lines, -5 lines 0 comments Download
M remoting/host/desktop_session_agent.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M remoting/host/desktop_session_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/desktop_session_proxy.cc View 7 chunks +10 lines, -12 lines 0 comments Download
M remoting/host/ipc_desktop_environment.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/ipc_desktop_environment.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
Sergey Ulanov
4 years ago (2016-11-23 23:58:07 UTC) #3
Hzj_jie
lgtm
4 years ago (2016-11-27 20:42:23 UTC) #7
Hzj_jie
https://codereview.chromium.org/2529533003/diff/1/remoting/host/chromoting_param_traits.h File remoting/host/chromoting_param_traits.h (right): https://codereview.chromium.org/2529533003/diff/1/remoting/host/chromoting_param_traits.h#newcode91 remoting/host/chromoting_param_traits.h:91: static void Log(const param_type& p, std::string* l); Share we ...
4 years ago (2016-11-28 00:10:45 UTC) #8
Sergey Ulanov
https://codereview.chromium.org/2529533003/diff/1/remoting/host/chromoting_param_traits.h File remoting/host/chromoting_param_traits.h (right): https://codereview.chromium.org/2529533003/diff/1/remoting/host/chromoting_param_traits.h#newcode91 remoting/host/chromoting_param_traits.h:91: static void Log(const param_type& p, std::string* l); On 2016/11/28 ...
4 years ago (2016-11-28 19:54:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529533003/1
4 years ago (2016-11-28 19:56:32 UTC) #11
Sergey Ulanov
+joedow for OWNERS approval
4 years ago (2016-11-28 22:29:11 UTC) #13
Sergey Ulanov
+rsesek for IPC changes approval -joedow (sorry, I misread the presubmit failure)
4 years ago (2016-11-28 22:34:11 UTC) #15
Robert Sesek
lgtm
4 years ago (2016-11-28 22:36:55 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 22:51:29 UTC) #18
commit-bot: I haz the power
4 years ago (2016-11-28 22:55:23 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c986f523c34dbaf0d943abae125094a72cc8c2f8
Cr-Commit-Position: refs/heads/master@{#434754}

Powered by Google App Engine
This is Rietveld 408576698