mac: Remove more media/base/mac glue unneeded now that we target 10.9

mac: Remove more media/base/mac glue unneeded now that we target 10.9

No real functional change, but instead of lazy-loading AVFoundation, it's
now linked like all the other system frameworks and loaded by the dynamic
linker at program startup.  While unlikely, this might have an effect
on startup time.

BUG=579648
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/14c7e868ac8b5908be34b1b7afc28ba485079899
Cr-Commit-Position: refs/heads/master@{#434776}

[Nico, 2016-11-22 21:06:43]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 21:07:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-11-22 21:07:52]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 21:08:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-11-22 21:10:18]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 21:10:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 21:17:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 21:17:36]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Nico, 2016-11-22 21:51:13]

Description was changed from

==========
mac: Remove more media/base/mac glue unneeded now that we target 10.9

BUG=579648
==========

to

==========
mac: Remove more media/base/mac glue unneeded now that we target 10.9

BUG=579648
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Nico, 2016-11-22 21:51:16]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 21:51:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 21:55:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 21:55:14]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Nico, 2016-11-22 22:04:33]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 22:04:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 22:08:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 22:08:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Nico, 2016-11-22 22:10:56]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 22:11:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-11-22 22:28:43]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 22:29:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-11-22 22:32:02]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 22:32:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-11-23 01:11:17]

Description was changed from

==========
mac: Remove more media/base/mac glue unneeded now that we target 10.9

BUG=579648
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
mac: Remove more media/base/mac glue unneeded now that we target 10.9

No real functional change, but instead of lazy-loading AVFoundation, it's
now linked like all the other system frameworks and loaded by the dynamic
linker at program startup.  While unlikely, this might have an effect
on startup time.

BUG=579648
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Nico, 2016-11-23 01:11:32]

thakis@chromium.org changed reviewers:
+ mcasas@chromium.org, sandersd@chromium.org

[commit-bot: I haz the power, 2016-11-23 01:37:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 01:37:07]

Dry run: This issue passed the CQ dry run.

[mcasas, 2016-11-23 02:27:52]

On 2016/11/23 01:11:33, Nico wrote:

gosh thanks! For removing that glue that turned into epoxy-gunk
by now: 
lgtm:
content/browser/renderer_host/media/video_capture_manager.* 
media/capture/video/*
media/device_monitors/* 

but video_capture_manager was touched by tommi@
after me, so perhaps you should double check with 
him.

[Nico, 2016-11-23 03:25:19]

thakis@chromium.org changed reviewers:
+ tommi@chromium.org

[Nico, 2016-11-23 03:25:20]

thanks! sandersd: media/base please

tommi: mcasas says that you might want to take a look at the
video_capture_manager change herein

[tommi (sloooow) - chröme, 2016-11-23 10:34:00]

On 2016/11/23 03:25:20, Nico wrote:
> thanks! sandersd: media/base please
> 
> tommi: mcasas says that you might want to take a look at the
> video_capture_manager change herein

I'm all for cleaning this up.  However, startup perf regression is a concern. 
See this conversation (e.g. look at comment #20):
https://codereview.chromium.org/1153063002/

Can you run those measurements again?

[Nico, 2016-11-23 13:04:25]

Can you link to what exactly you mean? That's just a cl, not measurements.
Wouldn't the perf bots find regressions? They seem to do that fine for
other cls of mine.

On Nov 23, 2016 5:34 AM, <tommi@chromium.org> wrote:

> On 2016/11/23 03:25:20, Nico wrote:
> > thanks! sandersd: media/base please
> >
> > tommi: mcasas says that you might want to take a look at the
> > video_capture_manager change herein
>
> I'm all for cleaning this up. However, startup perf regression is a
> concern.
> See this conversation (e.g. look at comment #20):
> https://codereview.chromium.org/1153063002/
>
> Can you run those measurements again?
>
>
>
> https://codereview.chromium.org/2529493002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tommi (sloooow) - chröme, 2016-11-23 14:15:53]

According to the local measurements mentioned in that CL, the impact was
10ms for a cold start, 2ms for subsequent runs. That should be easy to test.

On Wed, Nov 23, 2016 at 2:04 PM Nico Weber <thakis@chromium.org> wrote:

> Can you link to what exactly you mean? That's just a cl, not measurements.
> Wouldn't the perf bots find regressions? They seem to do that fine for
> other cls of mine.
>
> On Nov 23, 2016 5:34 AM, <tommi@chromium.org> wrote:
>
> On 2016/11/23 03:25:20, Nico wrote:
> > thanks! sandersd: media/base please
> >
> > tommi: mcasas says that you might want to take a look at the
> > video_capture_manager change herein
>
> I'm all for cleaning this up. However, startup perf regression is a
> concern.
> See this conversation (e.g. look at comment #20):
> https://codereview.chromium.org/1153063002/
>
> Can you run those measurements again?
>
>
>
> https://codereview.chromium.org/2529493002/
>
> --
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sandersd (OOO until July 31), 2016-11-23 19:09:31]

//media/base lgtm

[Nico, 2016-11-28 18:10:26]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-11-28 18:11:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 20:38:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 20:38:42]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Nico, 2016-11-28 20:44:24]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-11-28 20:45:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 21:04:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 21:04:33]

Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[Nico, 2016-11-28 21:09:11]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-11-28 21:10:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 23:37:28]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1480367351078260,
"parent_rev": "5d51f4f0df267e2dcc5aee73a972b84c6819f972", "commit_rev":
"bdb331a430944ebe529ce04d25e49fcb4d004dfe"}

[commit-bot: I haz the power, 2016-11-28 23:37:54]

Description was changed from

==========
mac: Remove more media/base/mac glue unneeded now that we target 10.9

No real functional change, but instead of lazy-loading AVFoundation, it's
now linked like all the other system frameworks and loaded by the dynamic
linker at program startup.  While unlikely, this might have an effect
on startup time.

BUG=579648
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
mac: Remove more media/base/mac glue unneeded now that we target 10.9

No real functional change, but instead of lazy-loading AVFoundation, it's
now linked like all the other system frameworks and loaded by the dynamic
linker at program startup.  While unlikely, this might have an effect
on startup time.

BUG=579648
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-28 23:37:55]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-11-28 23:40:47]

Description was changed from

==========
mac: Remove more media/base/mac glue unneeded now that we target 10.9

No real functional change, but instead of lazy-loading AVFoundation, it's
now linked like all the other system frameworks and loaded by the dynamic
linker at program startup.  While unlikely, this might have an effect
on startup time.

BUG=579648
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
mac: Remove more media/base/mac glue unneeded now that we target 10.9

No real functional change, but instead of lazy-loading AVFoundation, it's
now linked like all the other system frameworks and loaded by the dynamic
linker at program startup.  While unlikely, this might have an effect
on startup time.

BUG=579648
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/14c7e868ac8b5908be34b1b7afc28ba485079899
Cr-Commit-Position: refs/heads/master@{#434776}
==========

[commit-bot: I haz the power, 2016-11-28 23:40:48]

Patchset 8 (id:??) landed as
https://crrev.com/14c7e868ac8b5908be34b1b7afc28ba485079899
Cr-Commit-Position: refs/heads/master@{#434776}