Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2529483002: dart2js/kernel: Implement type literal and JS_INTERCEPTOR_CONSTANT (Closed)

Created:
4 years ago by sra1
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js/kernel: Implement type literal (constant) and JS_INTERCEPTOR_CONSTANT R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/9e80530980445258ea0308da4c4ea8d55a9334d6

Patch Set 1 #

Patch Set 2 : remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -2 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 3 chunks +48 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
4 years ago (2016-11-22 22:05:49 UTC) #4
Siggi Cherem (dart-lang)
lgtm
4 years ago (2016-11-22 22:35:47 UTC) #5
sra1
4 years ago (2016-11-22 22:44:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
9e80530980445258ea0308da4c4ea8d55a9334d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698