Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 2529473002: Implement search for other local elements. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add tests for function/method type parameters. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -7 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/search.dart View 1 2 chunks +13 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/search_test.dart View 1 7 chunks +88 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 1 month ago (2016-11-22 19:57:10 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2529473002/diff/1/pkg/analyzer/test/src/dart/analysis/search_test.dart File pkg/analyzer/test/src/dart/analysis/search_test.dart (right): https://codereview.chromium.org/2529473002/diff/1/pkg/analyzer/test/src/dart/analysis/search_test.dart#newcode165 pkg/analyzer/test/src/dart/analysis/search_test.dart:165: test_searchReferences_TypeParameterElement() async { Might also be good to ...
4 years, 1 month ago (2016-11-22 20:25:40 UTC) #2
scheglov
https://codereview.chromium.org/2529473002/diff/1/pkg/analyzer/test/src/dart/analysis/search_test.dart File pkg/analyzer/test/src/dart/analysis/search_test.dart (right): https://codereview.chromium.org/2529473002/diff/1/pkg/analyzer/test/src/dart/analysis/search_test.dart#newcode165 pkg/analyzer/test/src/dart/analysis/search_test.dart:165: test_searchReferences_TypeParameterElement() async { On 2016/11/22 20:25:40, Brian Wilkerson wrote: ...
4 years, 1 month ago (2016-11-22 20:47:56 UTC) #3
scheglov
4 years, 1 month ago (2016-11-22 20:48:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
366e7270484fda321df506c10383c356048481b4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698