test/unittests/compiler/js-typed-lowering-unittest.cc - Issue 2529463002: [Turbofan]: generic lowering can use a constant vector

Unified Diff: test/unittests/compiler/js-typed-lowering-unittest.cc

Issue 2529463002: [Turbofan]: generic lowering can use a constant vector (Closed)

Patch Set: Add verifier code. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: test/unittests/compiler/js-typed-lowering-unittest.cc

diff --git a/test/unittests/compiler/js-typed-lowering-unittest.cc b/test/unittests/compiler/js-typed-lowering-unittest.cc

index 6883052abbf533c4bdc781a3d86c5c7bc16f23e7..799635a0163b193904cb61286d080d6a4c718123 100644

--- a/test/unittests/compiler/js-typed-lowering-unittest.cc

+++ b/test/unittests/compiler/js-typed-lowering-unittest.cc

@@ -580,13 +580,12 @@ TEST_F(JSTypedLoweringTest, JSLoadPropertyFromExternalTypedArray) {

Node* key = Parameter(

Type::Range(kMinInt / element_size, kMaxInt / element_size, zone()));

Node* base = HeapConstant(array);

- Node* vector = UndefinedConstant();

Node* context = UndefinedConstant();

Node* effect = graph()->start();

Node* control = graph()->start();

- Reduction r = Reduce(graph()->NewNode(javascript()->LoadProperty(feedback),

- base, key, vector, context,

- EmptyFrameState(), effect, control));

+ Reduction r =

+ Reduce(graph()->NewNode(javascript()->LoadProperty(feedback), base, key,

+ context, EmptyFrameState(), effect, control));

Matcher<Node*> offset_matcher =

element_size == 1

@@ -622,13 +621,12 @@ TEST_F(JSTypedLoweringTest, JSLoadPropertyFromExternalTypedArrayWithSafeKey) {

if (min > max) std::swap(min, max);

Node* key = Parameter(Type::Range(min, max, zone()));

Node* base = HeapConstant(array);

- Node* vector = UndefinedConstant();

Node* context = UndefinedConstant();

Node* effect = graph()->start();

Node* control = graph()->start();

- Reduction r = Reduce(graph()->NewNode(javascript()->LoadProperty(feedback),

- base, key, vector, context,

- EmptyFrameState(), effect, control));

+ Reduction r =

+ Reduce(graph()->NewNode(javascript()->LoadProperty(feedback), base, key,

+ context, EmptyFrameState(), effect, control));

ASSERT_TRUE(r.Changed());

EXPECT_THAT(

@@ -660,13 +658,12 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArray) {

Node* base = HeapConstant(array);

Node* value =

Parameter(AccessBuilder::ForTypedArrayElement(type, true).type);

- Node* vector = UndefinedConstant();

Node* context = UndefinedConstant();

Node* effect = graph()->start();

Node* control = graph()->start();

VectorSlotPair feedback;

const Operator* op = javascript()->StoreProperty(language_mode, feedback);

- Node* node = graph()->NewNode(op, base, key, value, vector, context,

+ Node* node = graph()->NewNode(op, base, key, value, context,

EmptyFrameState(), effect, control);

Reduction r = Reduce(node);

@@ -704,7 +701,6 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithConversion) {

Type::Range(kMinInt / element_size, kMaxInt / element_size, zone()));

Node* base = HeapConstant(array);

Node* value = Parameter(Type::Any());

- Node* vector = UndefinedConstant();

Node* context = UndefinedConstant();

Node* effect = graph()->start();

Node* control = graph()->start();

@@ -714,7 +710,7 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithConversion) {

EmptyFrameState(), effect, control);

VectorSlotPair feedback;

const Operator* op = javascript()->StoreProperty(language_mode, feedback);

- Node* node = graph()->NewNode(op, base, key, value, vector, context,

+ Node* node = graph()->NewNode(op, base, key, value, context,

EmptyFrameState(), checkpoint, control);

Reduction r = Reduce(node);

@@ -759,13 +755,12 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithSafeKey) {

Node* key = Parameter(Type::Range(min, max, zone()));

Node* base = HeapConstant(array);

Node* value = Parameter(access.type);

- Node* vector = UndefinedConstant();

Node* context = UndefinedConstant();

Node* effect = graph()->start();

Node* control = graph()->start();

VectorSlotPair feedback;

const Operator* op = javascript()->StoreProperty(language_mode, feedback);

- Node* node = graph()->NewNode(op, base, key, value, vector, context,

+ Node* node = graph()->NewNode(op, base, key, value, context,

EmptyFrameState(), effect, control);

Reduction r = Reduce(node);

@@ -788,13 +783,12 @@ TEST_F(JSTypedLoweringTest, JSLoadNamedStringLength) {

VectorSlotPair feedback;

Handle<Name> name = factory()->length_string();

Node* const receiver = Parameter(Type::String(), 0);

- Node* const vector = Parameter(Type::Internal(), 1);

Node* const context = UndefinedConstant();

Node* const effect = graph()->start();

Node* const control = graph()->start();

- Reduction const r = Reduce(

- graph()->NewNode(javascript()->LoadNamed(name, feedback), receiver,

- vector, context, EmptyFrameState(), effect, control));

+ Reduction const r =

+ Reduce(graph()->NewNode(javascript()->LoadNamed(name, feedback), receiver,

+ context, EmptyFrameState(), effect, control));

ASSERT_TRUE(r.Changed());

EXPECT_THAT(r.replacement(), IsLoadField(AccessBuilder::ForStringLength(),

receiver, effect, control));

« no previous file with comments | « src/compiler/verifier.cc ('k') | no next file » | no next file with comments »