Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 2529463002: [Turbofan]: generic lowering can use a constant vector (Closed)

Created:
4 years, 1 month ago by mvstanton
Modified:
4 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan]: generic lowering can use a constant vector Since we are specializing on the native context, we don't have to load the vector from the closure. For one thing, this reduces the machinery for nodes that use a vector in their generic incarnation. BUG= R=mstarzinger@chromium.org Committed: https://crrev.com/3d31d251527e78b4a5aa7a21a899ac8993573c11 Cr-Commit-Position: refs/heads/master@{#41221}

Patch Set 1 #

Patch Set 2 : Fix compile error. #

Patch Set 3 : I should build release more. #

Patch Set 4 : Add verifier code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -125 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 2 3 6 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 2 3 6 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 5 chunks +12 lines, -87 lines 0 comments Download
M src/compiler/js-operator.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 3 2 chunks +24 lines, -2 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 2 7 chunks +12 lines, -18 lines 0 comments Download

Messages

Total messages: 24 (19 generated)
mvstanton
Hi Michael, N.B. - Here is the CL we discussed in the late afternoon/early evening ...
4 years, 1 month ago (2016-11-22 19:32:07 UTC) #1
Michael Starzinger
LGTM. But s/from the frame/from the closure/ in the CL description.
4 years ago (2016-11-23 09:44:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529463002/50001
4 years ago (2016-11-23 12:55:59 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:50001)
4 years ago (2016-11-23 13:23:45 UTC) #22
commit-bot: I haz the power
4 years ago (2016-11-23 13:23:54 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3d31d251527e78b4a5aa7a21a899ac8993573c11
Cr-Commit-Position: refs/heads/master@{#41221}

Powered by Google App Engine
This is Rietveld 408576698