Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2529443002: Show custom error message in payments UI. (Closed)

Created:
4 years, 1 month ago by please use gerrit instead
Modified:
4 years ago
Reviewers:
Ian Wen
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show custom error message in payments UI. If the merchant specifies an error message string when rejecting a shipping address, display this string as an error message in UI. BUG=648240 Committed: https://crrev.com/48ffb7ac26489de9ac469d8e26b4fda16f547191 Cr-Commit-Position: refs/heads/master@{#434231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java View 2 chunks +17 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/SectionInformation.java View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
please use gerrit instead
Ian, ptal. Screenshot in http://crbug.com/648240#c7. Test website https://rsolomakhin.github.io/pr/us/ was used to generate the screenshot.
4 years, 1 month ago (2016-11-22 18:27:51 UTC) #7
Ian Wen
lgtm
4 years ago (2016-11-23 19:16:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529443002/1
4 years ago (2016-11-23 19:17:41 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 20:09:38 UTC) #18
commit-bot: I haz the power
4 years ago (2016-11-23 20:13:38 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48ffb7ac26489de9ac469d8e26b4fda16f547191
Cr-Commit-Position: refs/heads/master@{#434231}

Powered by Google App Engine
This is Rietveld 408576698