Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2529433004: Update signout icon and more_settings icon on the md shelf (Closed)

Created:
4 years ago by xiaoyinh(OOO Sep 11-29)
Modified:
4 years ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

update signout icon and more_settings icon on the md shelf BUG=667868 TEST=Manually tested on signin screen and lock screen. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7ce15669e0917b7d72d2d36d40462009b296b3d4 Cr-Commit-Position: refs/heads/master@{#435420}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Simplify svg files #

Patch Set 3 : rebase #

Messages

Total messages: 26 (18 generated)
xiaoyinh(OOO Sep 11-29)
oshima@, could you take a look at chrome/app/theme/* alemate@, could you take a look at ...
4 years ago (2016-11-23 17:41:18 UTC) #5
Alexander Alekseev
lgtm https://codereview.chromium.org/2529433004/diff/1/chrome/browser/resources/chromeos/login/images/1x/more-settings.svg File chrome/browser/resources/chromeos/login/images/1x/more-settings.svg (right): https://codereview.chromium.org/2529433004/diff/1/chrome/browser/resources/chromeos/login/images/1x/more-settings.svg#newcode1 chrome/browser/resources/chromeos/login/images/1x/more-settings.svg:1: <?xml version="1.0" encoding="UTF-8"?> nit: could you minimize this ...
4 years ago (2016-11-24 00:32:57 UTC) #8
xiaoyinh(OOO Sep 11-29)
https://codereview.chromium.org/2529433004/diff/1/chrome/browser/resources/chromeos/login/images/1x/more-settings.svg File chrome/browser/resources/chromeos/login/images/1x/more-settings.svg (right): https://codereview.chromium.org/2529433004/diff/1/chrome/browser/resources/chromeos/login/images/1x/more-settings.svg#newcode1 chrome/browser/resources/chromeos/login/images/1x/more-settings.svg:1: <?xml version="1.0" encoding="UTF-8"?> On 2016/11/24 00:32:57, Alexander Alekseev wrote: ...
4 years ago (2016-11-28 21:42:19 UTC) #11
oshima
lgtm
4 years ago (2016-11-30 17:38:13 UTC) #14
oshima
On 2016/11/30 17:38:13, oshima wrote: > lgtm btw, you can tbr removal.
4 years ago (2016-11-30 17:38:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529433004/40001
4 years ago (2016-11-30 21:21:25 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-30 21:25:50 UTC) #24
commit-bot: I haz the power
4 years ago (2016-11-30 21:28:27 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7ce15669e0917b7d72d2d36d40462009b296b3d4
Cr-Commit-Position: refs/heads/master@{#435420}

Powered by Google App Engine
This is Rietveld 408576698