Introduce resetLayout(), to offload layoutBlockFlow().

Introduce resetLayout(), to offload layoutBlockFlow().

Committed: https://crrev.com/053608703a4f735d5bf48fdef38e76f4d4678c9c
Cr-Commit-Position: refs/heads/master@{#435471}

[mstensho (USE GERRIT), 2016-11-29 14:24:01]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 14:24:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mstensho (USE GERRIT), 2016-11-29 14:26:09]

mstensho@opera.com changed reviewers:
+ szager@chromium.org

[commit-bot: I haz the power, 2016-11-29 15:44:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 15:44:28]

Dry run: This issue passed the CQ dry run.

[mstensho (USE GERRIT), 2016-11-30 18:35:51]

ping?

[szager1, 2016-11-30 20:33:29]

lgtm with nit.

https://codereview.chromium.org/2529423003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right):

https://codereview.chromium.org/2529423003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:473: if
(m_paginationStateChanged) {
Should this be inside resetLayout?  Maybe pass a LayoutState to that method?

[mstensho (USE GERRIT), 2016-11-30 20:47:58]

https://codereview.chromium.org/2529423003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right):

https://codereview.chromium.org/2529423003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:473: if
(m_paginationStateChanged) {
On 2016/11/30 20:33:28, szager1 wrote:
> Should this be inside resetLayout?  Maybe pass a LayoutState to that method?

This is something that ideally should only be done once per layoutBlock() call
(pagination state only changes when style changes, or when entering/leaving
print preview), but since LayoutState is created here in layoutBlockFlow(),
m_paginationStateChanged needs to be here as well. But I intend to move them
both to layoutBlock().

I could put it in resetLayout() temporarily in the meantime, of course. But the
code move from layoutBlockFlow() to layoutBlock() that I'm talking about is only
2-3 CLs down the road.

So I suggest that we keep it here for now, if that's fine with you.

[szager1, 2016-11-30 22:02:26]

On 2016/11/30 20:47:58, mstensho wrote:
>
https://codereview.chromium.org/2529423003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right):
> 
>
https://codereview.chromium.org/2529423003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:473: if
> (m_paginationStateChanged) {
> On 2016/11/30 20:33:28, szager1 wrote:
> > Should this be inside resetLayout?  Maybe pass a LayoutState to that method?
> 
> This is something that ideally should only be done once per layoutBlock() call
> (pagination state only changes when style changes, or when entering/leaving
> print preview), but since LayoutState is created here in layoutBlockFlow(),
> m_paginationStateChanged needs to be here as well. But I intend to move them
> both to layoutBlock().
> 
> I could put it in resetLayout() temporarily in the meantime, of course. But
the
> code move from layoutBlockFlow() to layoutBlock() that I'm talking about is
only
> 2-3 CLs down the road.
> 
> So I suggest that we keep it here for now, if that's fine with you.

That's fine, lgtm.

[mstensho (USE GERRIT), 2016-11-30 22:07:54]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-11-30 22:08:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 23:26:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480543674954290, "parent_rev":
"06a978c9774e5b8c3465fbf262c0c7e83fc54b75", "commit_rev":
"580177fbea2e1a42839561cdc4ea50a36bbc7af8"}

[commit-bot: I haz the power, 2016-11-30 23:27:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-30 23:30:24]

Description was changed from

==========
Introduce resetLayout(), to offload layoutBlockFlow().
==========

to

==========
Introduce resetLayout(), to offload layoutBlockFlow().

Committed: https://crrev.com/053608703a4f735d5bf48fdef38e76f4d4678c9c
Cr-Commit-Position: refs/heads/master@{#435471}
==========

[commit-bot: I haz the power, 2016-11-30 23:30:26]

Patchset 1 (id:??) landed as
https://crrev.com/053608703a4f735d5bf48fdef38e76f4d4678c9c
Cr-Commit-Position: refs/heads/master@{#435471}