Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 25294003: Add 3 color variant to gradient bench, include scale in name, add more benchs (Closed)

Created:
7 years, 2 months ago by bsalomon
Modified:
7 years, 2 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add 3 color variant to gradient bench, include scale in name, add more benchs Committed: http://code.google.com/p/skia/source/detail?r=11536

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M bench/GradientBench.cpp View 1 5 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
7 years, 2 months ago (2013-09-30 18:20:32 UTC) #1
reed1
lgtm w/ comment suggestion https://codereview.chromium.org/25294003/diff/1/bench/GradientBench.cpp File bench/GradientBench.cpp (right): https://codereview.chromium.org/25294003/diff/1/bench/GradientBench.cpp#newcode38 bench/GradientBench.cpp:38: static const GradData gGradData[] = ...
7 years, 2 months ago (2013-09-30 18:34:09 UTC) #2
bsalomon
https://codereview.chromium.org/25294003/diff/1/bench/GradientBench.cpp File bench/GradientBench.cpp (right): https://codereview.chromium.org/25294003/diff/1/bench/GradientBench.cpp#newcode38 bench/GradientBench.cpp:38: static const GradData gGradData[] = { On 2013/09/30 18:34:09, ...
7 years, 2 months ago (2013-09-30 18:53:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/25294003/5001
7 years, 2 months ago (2013-09-30 18:53:59 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-09-30 19:41:12 UTC) #5
Message was sent while issue was closed.
Change committed as 11536

Powered by Google App Engine
This is Rietveld 408576698