Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2529383004: Convert PermissionsBlacklist flag to base::Feature. (Closed)

Created:
4 years ago by meredithl
Modified:
4 years ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert PermissionsBlacklist flag to base::Feature. Features are the new canonical way of flag driven development. Permissions Blacklist flag has been updated to reflect this. BUG=561867 Committed: https://crrev.com/5a7f78b5c040eb5a1af75afab1d02dfe156baac6 Cr-Commit-Position: refs/heads/master@{#435172}

Patch Set 1 #

Patch Set 2 : Remove switch #

Patch Set 3 : Add Permission Blacklist feature to histograms.xml #

Messages

Total messages: 30 (18 generated)
meredithl
PTAL, thanks. :)
4 years ago (2016-11-29 06:02:27 UTC) #4
dominickn
lgtm
4 years ago (2016-11-29 06:05:32 UTC) #5
kcarattini
LGTM. Thanks, Meredith!
4 years ago (2016-11-29 06:10:06 UTC) #6
meredithl
PTAL at histograms.xml Thanks!
4 years ago (2016-11-29 22:25:19 UTC) #11
Ilya Sherman
histograms.xml lgtm
4 years ago (2016-11-30 00:34:51 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529383004/40001
4 years ago (2016-11-30 00:43:20 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on ...
4 years ago (2016-11-30 02:45:26 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529383004/40001
4 years ago (2016-11-30 02:51:03 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-30 04:51:55 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529383004/40001
4 years ago (2016-11-30 08:30:48 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-30 08:35:58 UTC) #28
commit-bot: I haz the power
4 years ago (2016-11-30 08:39:59 UTC) #30
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5a7f78b5c040eb5a1af75afab1d02dfe156baac6
Cr-Commit-Position: refs/heads/master@{#435172}

Powered by Google App Engine
This is Rietveld 408576698