[Android app restrictions] Hide unused and improve descriptions.

[Android app restrictions] Hide unused and improve descriptions.

Remove future and deprecated policies from app_restrictions.xml and
restriction_values.xml, hence making them invisible to Android policy
managers. Also include all lines of multiline descriptions of policies.

BUG=616800
BUG=616801
Committed: https://crrev.com/0d9428bb6b7d6a77e1d68f26d5dad81b224148d5
Cr-Commit-Position: refs/heads/master@{#434949}

[aberent, 2016-11-28 14:52:33]

aberent@chromium.org changed reviewers:
+ bartfab@chromium.org, thestig@chromium.org

[aberent, 2016-11-28 14:52:33]

bartfab@chromium.org: Please review changes in generate_policy_source.py

thestig@chromium.org: Please review changes in grit (android_policy_writer*).

[aberent, 2016-11-28 14:53:58]

Description was changed from

==========
[Android app restrictions] Hide unused and improve descriptions.

Remove future and decremented policies from app_restrictions.xml and
restriction_values.xml, hence making them invisible to Android policy
managers. Also include all lines of multiline descriptions of policies.

BUG=616800
BUG=616801
==========

to

==========
[Android app restrictions] Hide unused and improve descriptions.

Remove future and decremented policies from app_restrictions.xml and
restriction_values.xml, hence making them invisible to Android policy
managers. Also include all lines of multiline descriptions of policies.

BUG=616800
BUG=616801
==========

[aberent, 2016-11-28 14:53:58]

aberent@chromium.org changed reviewers:
- bartfab@chromium.org, thestig@chromium.org

[aberent, 2016-11-28 14:58:25]

aberent@chromium.org changed reviewers:
+ pastarmovj@chromium.org, thakis@chromium.org

[aberent, 2016-11-28 14:58:25]

Changing reviewers, since both previous reviewers had notes saying slow or OOO.

pastarmovj@chromium.org: Please review changes in generate_policy_source.py

thakis@chromium.org: Please review changes in grit (android_policy_writer*).

[pastarmovj, 2016-11-28 15:33:55]

nit: Please change s/decremented/deprecated/ in the CL description text.

One question too: If a given policy has a value but is then deprecated. What is
the behavior on Android? I mean obviously Chrome will not respect it anymore and
will show it as deprecated in chrome://policy but what are the policy tools
goind to do? Are they clearing such policies? Otherwhise the user will end up
with potentially many deprecated policies they will not see because they are
hidden due to deprecation. 

For future ones totally on board with the change.

https://codereview.chromium.org/2529383003/diff/1/tools/grit/grit/format/poli...
File tools/grit/grit/format/policy_templates/writers/android_policy_writer.py
(right):

https://codereview.chromium.org/2529383003/diff/1/tools/grit/grit/format/poli...
tools/grit/grit/format/policy_templates/writers/android_policy_writer.py:71: #
Get the first line of the policy description.
nit: This comment is not valid anymore right?

[aberent, 2016-11-28 15:49:08]

Description was changed from

==========
[Android app restrictions] Hide unused and improve descriptions.

Remove future and decremented policies from app_restrictions.xml and
restriction_values.xml, hence making them invisible to Android policy
managers. Also include all lines of multiline descriptions of policies.

BUG=616800
BUG=616801
==========

to

==========
[Android app restrictions] Hide unused and improve descriptions.

Remove future and deprecated policies from app_restrictions.xml and
restriction_values.xml, hence making them invisible to Android policy
managers. Also include all lines of multiline descriptions of policies.

BUG=616800
BUG=616801
==========

[aberent, 2016-11-28 16:13:52]

On 2016/11/28 15:33:55, pastarmovj wrote:
> nit: Please change s/decremented/deprecated/ in the CL description text.
Done
> 
> One question too: If a given policy has a value but is then deprecated. What
is
> the behavior on Android? I mean obviously Chrome will not respect it anymore
and
> will show it as deprecated in chrome://policy but what are the policy tools
> goind to do? Are they clearing such policies? Otherwhise the user will end up
> with potentially many deprecated policies they will not see because they are
> hidden due to deprecation.

Tools that are modifying the policies get all of them from
GetApplicationRestrictions
(https://developer.android.com/reference/android/app/admin/DevicePolicyManager...,
java.lang.String)) so can compare the list with the ones referenced from the
manifest (see
https://developer.android.com/reference/android/content/RestrictionsManager.h...).
As such it is certainly possible for tools to clear unknown policies, and
Android's sample policy app (Test DPC) does so if one taps Load Manifest
Restrictions.

If a tool simply writes policies without reading what was previously there, then
this will clear all other restrictions (see
https://developer.android.com/reference/android/app/admin/DevicePolicyManager...,
java.lang.String, android.os.Bundle)).

As such, while tools could get this wrong, I think they have a good chance of
getting this right.

> 
> For future ones totally on board with the change.
> 
>
https://codereview.chromium.org/2529383003/diff/1/tools/grit/grit/format/poli...
> File tools/grit/grit/format/policy_templates/writers/android_policy_writer.py
> (right):
> 
>
https://codereview.chromium.org/2529383003/diff/1/tools/grit/grit/format/poli...
> tools/grit/grit/format/policy_templates/writers/android_policy_writer.py:71: #
> Get the first line of the policy description.
> nit: This comment is not valid anymore right?

[aberent, 2016-11-28 16:23:32]

https://codereview.chromium.org/2529383003/diff/1/tools/grit/grit/format/poli...
File tools/grit/grit/format/policy_templates/writers/android_policy_writer.py
(right):

https://codereview.chromium.org/2529383003/diff/1/tools/grit/grit/format/poli...
tools/grit/grit/format/policy_templates/writers/android_policy_writer.py:71: #
Get the first line of the policy description.
On 2016/11/28 15:33:55, pastarmovj wrote:
> nit: This comment is not valid anymore right?

Done.

[pastarmovj, 2016-11-28 16:25:27]

lgtm

[Nico, 2016-11-28 17:22:35]

lgtm

[aberent, 2016-11-29 09:14:50]

The CQ bit was checked by aberent@chromium.org

[commit-bot: I haz the power, 2016-11-29 09:15:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 10:31:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480410890911170,
"parent_rev": "46f98a8d9d98d0f0bb2a80f54f0193726a26c0d6", "commit_rev":
"54e31049bcbcd137e0f7cf1ee82ae9f42ca28c9e"}

[commit-bot: I haz the power, 2016-11-29 10:31:39]

Description was changed from

==========
[Android app restrictions] Hide unused and improve descriptions.

Remove future and deprecated policies from app_restrictions.xml and
restriction_values.xml, hence making them invisible to Android policy
managers. Also include all lines of multiline descriptions of policies.

BUG=616800
BUG=616801
==========

to

==========
[Android app restrictions] Hide unused and improve descriptions.

Remove future and deprecated policies from app_restrictions.xml and
restriction_values.xml, hence making them invisible to Android policy
managers. Also include all lines of multiline descriptions of policies.

BUG=616800
BUG=616801
==========

[commit-bot: I haz the power, 2016-11-29 10:31:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 10:34:23]

Description was changed from

==========
[Android app restrictions] Hide unused and improve descriptions.

Remove future and deprecated policies from app_restrictions.xml and
restriction_values.xml, hence making them invisible to Android policy
managers. Also include all lines of multiline descriptions of policies.

BUG=616800
BUG=616801
==========

to

==========
[Android app restrictions] Hide unused and improve descriptions.

Remove future and deprecated policies from app_restrictions.xml and
restriction_values.xml, hence making them invisible to Android policy
managers. Also include all lines of multiline descriptions of policies.

BUG=616800
BUG=616801

Committed: https://crrev.com/0d9428bb6b7d6a77e1d68f26d5dad81b224148d5
Cr-Commit-Position: refs/heads/master@{#434949}
==========

[commit-bot: I haz the power, 2016-11-29 10:34:24]

Patchset 2 (id:??) landed as
https://crrev.com/0d9428bb6b7d6a77e1d68f26d5dad81b224148d5
Cr-Commit-Position: refs/heads/master@{#434949}