[inspector] Split off interface-types.h

src/debug/debug-interface.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_DEBUG_DEBUG_INTERFACE_H_
 #define V8_DEBUG_DEBUG_INTERFACE_H_
 
 #include "include/v8-debug.h"
 #include "include/v8-util.h"
 #include "include/v8.h"
@@ skipping 184 matching lines @@
                                    v8::Local<v8::Object> script);
 
    private:
     int GetSourcePosition(const Location& location) const;
   };
 
   static void GetLoadedScripts(Isolate* isolate,
                                PersistentValueVector<Script>& scripts);
 
   /**
+   * The result of disassembling a wasm function.
+   * Consists of the disassembly string and an offset table mapping wasm byte
+   * offsets to line and column in the disassembly.
+   * The offset table consists of entries <byte_offset, line, column> and is
+   * guaranteed to be ordered by the byte_offset.
+   */
+  struct WasmDisassembly {
+    using offset_table_entry = std::tuple<uint32_t, int, int>;

[kozy, 2016/11/29 23:52:44]

Could we replace this tuple with struct as well?

+    std::string disassembly;
+    std::vector<offset_table_entry> offset_table;
+  };
+
+  /**
    * Compute the disassembly of a wasm function.
-   * Returns the disassembly string and a list of <byte_offset, line, column>
-   * entries, mapping wasm byte offsets to line and column in the disassembly.
-   * The list is guaranteed to be ordered by the byte_offset.
    */
-  static std::pair<std::string, std::vector<std::tuple<uint32_t, int, int>>>
-  DisassembleWasmFunction(Isolate* isolate, v8::Local<v8::Object> script,
-                          int function_index);
+  static WasmDisassembly DisassembleWasmFunction(Isolate* isolate,
+                                                 v8::Local<v8::Object> script,
+                                                 int function_index);
+
   static MaybeLocal<UnboundScript> CompileInspectorScript(Isolate* isolate,
                                                           Local<String> source);
 };
 
 }  // namespace v8
 
 #endif  // V8_DEBUG_DEBUG_INTERFACE_H_