Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2529373002: Reland of [cleanup] Refactor builtins-number.cc (Closed)

Created:
4 years ago by Jakob Kummerow
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [cleanup] Refactor builtins-number.cc Introducing a TF_BUILTIN macro that wraps CodeStubAssembler usage into a convenient interface (using a subclass under the hood). No changes since previous attempt; this was only reverted because it blocked another revert. Original review: https://codereview.chromium.org/2517833005/ TBR=ishell@chromium.org Committed: https://crrev.com/c49148969375a2454e78a8b2a58b952826012fd6 Cr-Commit-Position: refs/heads/master@{#41315}

Patch Set 1 #

Patch Set 2 : rebased (trivial) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+753 lines, -936 lines) Patch
M src/builtins/builtins-number.cc View 1 4 chunks +728 lines, -936 lines 0 comments Download
M src/builtins/builtins-utils.h View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Jakob Kummerow
Created Reland of [cleanup] Refactor builtins-number.cc
4 years ago (2016-11-28 11:42:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529373002/70001
4 years ago (2016-11-28 12:15:50 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:70001)
4 years ago (2016-11-28 12:46:17 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-28 12:46:33 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c49148969375a2454e78a8b2a58b952826012fd6
Cr-Commit-Position: refs/heads/master@{#41315}

Powered by Google App Engine
This is Rietveld 408576698