Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2529343003:
[deoptimizer] Remove dead Code::LookupRangeInHandlerTable. (Closed)
|
Created:
4 years ago by Michael Starzinger Modified:
4 years ago Reviewers:
Jarin CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[deoptimizer] Remove dead Code::LookupRangeInHandlerTable.
This removes the supporting function to perform a range-lookup in the
exception handler table for unoptimized code. Such tables are by now
guaranteed to be empty, the deoptimizer cannot encounter this case.
R=jarin@chromium.org
Committed: https://crrev.com/1f27ed9d7da78904e0418364c6394f913eabbe70
Committed: https://crrev.com/ac8860737507de258ca0bb9dc6fe17afc213b18b
Cr-Original-Commit-Position: refs/heads/master@{#41318}
Cr-Commit-Position: refs/heads/master@{#41323}
Patch Set 1 #Patch Set 2 : Rebased. #Patch Set 3 : Rebased. #
Messages
Total messages: 34 (24 generated)
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/16887)
lgtm. Thanks!
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mstarzinger@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org Link to the patchset: https://codereview.chromium.org/2529343003/#ps20001 (title: "Rebased.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. This removes the supporintg function to perform a range-lookup in the exception handler table for unoptimized code. Such tables are by now guaranteed to be empty, the deoptimizer cannot encounter this case. R=jarin@chromium.org ========== to ========== [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. This removes the supporting function to perform a range-lookup in the exception handler table for unoptimized code. Such tables are by now guaranteed to be empty, the deoptimizer cannot encounter this case. R=jarin@chromium.org ==========
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480339410304370,
"parent_rev": "2e7dc26e4499092b8e6bed4b7ce492d1e4d7fc45", "commit_rev":
"b05f6a87b983f97926382d3aa01e94ef3bfccc3a"}
Message was sent while issue was closed.
Description was changed from ========== [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. This removes the supporting function to perform a range-lookup in the exception handler table for unoptimized code. Such tables are by now guaranteed to be empty, the deoptimizer cannot encounter this case. R=jarin@chromium.org ========== to ========== [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. This removes the supporting function to perform a range-lookup in the exception handler table for unoptimized code. Such tables are by now guaranteed to be empty, the deoptimizer cannot encounter this case. R=jarin@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. This removes the supporting function to perform a range-lookup in the exception handler table for unoptimized code. Such tables are by now guaranteed to be empty, the deoptimizer cannot encounter this case. R=jarin@chromium.org ========== to ========== [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. This removes the supporting function to perform a range-lookup in the exception handler table for unoptimized code. Such tables are by now guaranteed to be empty, the deoptimizer cannot encounter this case. R=jarin@chromium.org Committed: https://crrev.com/1f27ed9d7da78904e0418364c6394f913eabbe70 Cr-Commit-Position: refs/heads/master@{#41318} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1f27ed9d7da78904e0418364c6394f913eabbe70 Cr-Commit-Position: refs/heads/master@{#41318}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2536673002/ by mstarzinger@chromium.org. The reason for reverting is: Seems to break TSAN builds. https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/12....
Message was sent while issue was closed.
Description was changed from ========== [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. This removes the supporting function to perform a range-lookup in the exception handler table for unoptimized code. Such tables are by now guaranteed to be empty, the deoptimizer cannot encounter this case. R=jarin@chromium.org Committed: https://crrev.com/1f27ed9d7da78904e0418364c6394f913eabbe70 Cr-Commit-Position: refs/heads/master@{#41318} ========== to ========== [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. This removes the supporting function to perform a range-lookup in the exception handler table for unoptimized code. Such tables are by now guaranteed to be empty, the deoptimizer cannot encounter this case. R=jarin@chromium.org Committed: https://crrev.com/1f27ed9d7da78904e0418364c6394f913eabbe70 Cr-Commit-Position: refs/heads/master@{#41318} ==========
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Rebased. Relanding.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mstarzinger@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org Link to the patchset: https://codereview.chromium.org/2529343003/#ps40001 (title: "Rebased.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480348595078750,
"parent_rev": "ffccffba1ba9eea61290f540bc3dbe5a73d7457d", "commit_rev":
"8f4dd30cba0396d678ec1ec25aced87c3d2d6974"}
Message was sent while issue was closed.
Description was changed from ========== [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. This removes the supporting function to perform a range-lookup in the exception handler table for unoptimized code. Such tables are by now guaranteed to be empty, the deoptimizer cannot encounter this case. R=jarin@chromium.org Committed: https://crrev.com/1f27ed9d7da78904e0418364c6394f913eabbe70 Cr-Commit-Position: refs/heads/master@{#41318} ========== to ========== [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. This removes the supporting function to perform a range-lookup in the exception handler table for unoptimized code. Such tables are by now guaranteed to be empty, the deoptimizer cannot encounter this case. R=jarin@chromium.org Committed: https://crrev.com/1f27ed9d7da78904e0418364c6394f913eabbe70 Cr-Commit-Position: refs/heads/master@{#41318} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. This removes the supporting function to perform a range-lookup in the exception handler table for unoptimized code. Such tables are by now guaranteed to be empty, the deoptimizer cannot encounter this case. R=jarin@chromium.org Committed: https://crrev.com/1f27ed9d7da78904e0418364c6394f913eabbe70 Cr-Commit-Position: refs/heads/master@{#41318} ========== to ========== [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. This removes the supporting function to perform a range-lookup in the exception handler table for unoptimized code. Such tables are by now guaranteed to be empty, the deoptimizer cannot encounter this case. R=jarin@chromium.org Committed: https://crrev.com/1f27ed9d7da78904e0418364c6394f913eabbe70 Committed: https://crrev.com/ac8860737507de258ca0bb9dc6fe17afc213b18b Cr-Original-Commit-Position: refs/heads/master@{#41318} Cr-Commit-Position: refs/heads/master@{#41323} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/ac8860737507de258ca0bb9dc6fe17afc213b18b Cr-Commit-Position: refs/heads/master@{#41323} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
