Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2529333002: Only include debugger.gyp for isolation (Closed)

Created:
4 years ago by jochen (gone - plz use gerrit)
Modified:
4 years ago
Reviewers:
Yang, Michael Achenbach
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Only include debugger.gyp for isolation R=yangguo@chromium.org,machenbach@chromium.org BUG= Committed: https://crrev.com/b1a49fc2c307494ff042775da662f5df2b3faf9f Cr-Commit-Position: refs/heads/master@{#41300}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M gypfiles/all.gyp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
jochen (gone - plz use gerrit)
4 years ago (2016-11-28 09:37:49 UTC) #1
Michael Achenbach
Why? Like this we wouldn't run inspector tests, wouldn't we? Or don't we care in ...
4 years ago (2016-11-28 09:43:38 UTC) #4
jochen (gone - plz use gerrit)
On 2016/11/28 at 09:43:38, machenbach wrote: > Why? Like this we wouldn't run inspector tests, ...
4 years ago (2016-11-28 09:49:40 UTC) #5
Michael Achenbach
Alright. Didn't look at the new condition close enough. LGTM
4 years ago (2016-11-28 09:52:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529333002/1
4 years ago (2016-11-28 09:56:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 10:03:10 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-28 10:03:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1a49fc2c307494ff042775da662f5df2b3faf9f
Cr-Commit-Position: refs/heads/master@{#41300}

Powered by Google App Engine
This is Rietveld 408576698