Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 2529303003: DevTools: move FileSystemMapping from Workspace to Persistence (Closed)

Created:
4 years ago by lushnikov
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: move FileSystemMapping from Workspace to Persistence This patch moves the FileSystemMapping under the persistence/ module. This is along the plan which is outlined in the tracking bug. Two things to note here: - The FileSystemMapping object is still a singleton, some tests rely on this - The patch addes a dependency from settings/ to persistence/. Ideally, we should make settings/ extendable via the Runtime, but that's a different story. BUG=649837

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -457 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/isolated-filesystem-test.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-do-not-bind-dirty-sourcecode.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-go-to-file-dialog.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-merge-editor-tabs.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-move-breakpoints.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-navigator.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-search-across-all-files.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sync-content.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/file-system-mapping.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/file-system-mapping-overrides.html View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-mapping.html View 1 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js View 2 chunks +5 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/persistence/FileSystemMapping.js View 10 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/EditFileSystemView.js View 1 7 chunks +17 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/module.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 3 chunks +5 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/workspace/FileSystemMapping.js View 1 chunk +0 lines, -390 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/module.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (6 generated)
lushnikov
4 years ago (2016-11-29 00:32:50 UTC) #3
please, take a look

Powered by Google App Engine
This is Rietveld 408576698