[PhysicalWeb] Add fake data source and helpers for testing.

[PhysicalWeb] Add fake data source and helpers for testing.

As it was suggested in codereview.chromium.org/2517113005, this CL adds
FakePhysicalWebDataSource. In addition to this, it adds helper functions
for creating physical web pages for tests.

BUG=None

Committed: https://crrev.com/97c594d8353f99139fe51b912991a2a3c097dc26
Cr-Commit-Position: refs/heads/master@{#434912}

[vitaliii, 2016-11-28 08:45:10]

The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 08:45:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vitaliii, 2016-11-28 08:46:04]

vitaliii@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[vitaliii, 2016-11-28 08:46:05]

Hi Olivier,

PTAL.

[commit-bot: I haz the power, 2016-11-28 08:48:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 08:48:51]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[vitaliii, 2016-11-28 08:49:10]

The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 08:49:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Olivier, 2016-11-28 08:52:05]

LGTM with nits

https://codereview.chromium.org/2529303002/diff/1/components/physical_web/dat...
File components/physical_web/data_source/fake_physical_web_data_source.cc
(right):

https://codereview.chromium.org/2529303002/diff/1/components/physical_web/dat...
components/physical_web/data_source/fake_physical_web_data_source.cc:26: //
TODO(vitaliii): Do not set integer once crbug.com/667722 is resolved.
Can you use the format 
// TODO(crbug.com/667722): Remove workaround once timestamp is fixed.

https://codereview.chromium.org/2529303002/diff/1/components/physical_web/dat...
File components/physical_web/data_source/fake_physical_web_data_source.h
(right):

https://codereview.chromium.org/2529303002/diff/1/components/physical_web/dat...
components/physical_web/data_source/fake_physical_web_data_source.h:16: class
DictionaryValue;
nit: alphabetical order.

[vitaliii, 2016-11-28 08:58:23]

I addressed your nits, no need to look.
Thank you for the review!

https://codereview.chromium.org/2529303002/diff/1/components/physical_web/dat...
File components/physical_web/data_source/fake_physical_web_data_source.cc
(right):

https://codereview.chromium.org/2529303002/diff/1/components/physical_web/dat...
components/physical_web/data_source/fake_physical_web_data_source.cc:26: //
TODO(vitaliii): Do not set integer once crbug.com/667722 is resolved.
On 2016/11/28 08:52:05, Olivier Robin wrote:
> Can you use the format 
> // TODO(crbug.com/667722): Remove workaround once timestamp is fixed.

Done.
I stopped on 
// TODO(crbug.com/667722): Remove this integer workaround once timestamp is
// fixed.

https://codereview.chromium.org/2529303002/diff/1/components/physical_web/dat...
File components/physical_web/data_source/fake_physical_web_data_source.h
(right):

https://codereview.chromium.org/2529303002/diff/1/components/physical_web/dat...
components/physical_web/data_source/fake_physical_web_data_source.h:16: class
DictionaryValue;
On 2016/11/28 08:52:05, Olivier Robin wrote:
> nit: alphabetical order.

Done.

[vitaliii, 2016-11-28 08:58:37]

The CQ bit was checked by vitaliii@chromium.org

[vitaliii, 2016-11-28 08:58:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
olivierrobin@chromium.org
Link to the patchset: https://codereview.chromium.org/2529303002/#ps40001
(title: "olivierrobin@ nits.")

[vitaliii, 2016-11-28 08:58:46]

The CQ bit was unchecked by vitaliii@chromium.org

[commit-bot: I haz the power, 2016-11-28 08:58:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vitaliii, 2016-11-28 09:01:19]

The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 09:01:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vitaliii, 2016-11-28 09:03:32]

vitaliii@chromium.org changed reviewers:
+ mpearson@chromium.org

[vitaliii, 2016-11-28 09:03:32]

Hi mpearson@,

Could you have a look at my omnibox tests change?

[commit-bot: I haz the power, 2016-11-28 10:16:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 10:16:34]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[vitaliii, 2016-11-28 10:50:35]

The CQ bit was checked by vitaliii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 10:50:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 11:47:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 11:47:56]

Dry run: This issue passed the CQ dry run.

[Mark P, 2016-11-28 17:31:17]

components/omnibox/browser/... lgtm
(I assume that's all you wanted me to review.)

--mark

[vitaliii, 2016-11-29 06:26:57]

The CQ bit was checked by vitaliii@chromium.org

[vitaliii, 2016-11-29 06:26:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
olivierrobin@chromium.org
Link to the patchset: https://codereview.chromium.org/2529303002/#ps60001
(title: "trybot fix.")

[commit-bot: I haz the power, 2016-11-29 06:27:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 06:32:53]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480400817389820,
"parent_rev": "9c75ef743101ac05374cf1196a1c5269ccde7cf1", "commit_rev":
"acf02e2cf30e7e0778b2c81af7a95522c5ebe024"}

[commit-bot: I haz the power, 2016-11-29 06:33:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-29 06:35:56]

Description was changed from

==========
[PhysicalWeb] Add fake data source and helpers for testing.

As it was suggested in codereview.chromium.org/2517113005, this CL adds
FakePhysicalWebDataSource. In addition to this, it adds helper functions
for creating physical web pages for tests.

BUG=None
==========

to

==========
[PhysicalWeb] Add fake data source and helpers for testing.

As it was suggested in codereview.chromium.org/2517113005, this CL adds
FakePhysicalWebDataSource. In addition to this, it adds helper functions
for creating physical web pages for tests.

BUG=None

Committed: https://crrev.com/97c594d8353f99139fe51b912991a2a3c097dc26
Cr-Commit-Position: refs/heads/master@{#434912}
==========

[commit-bot: I haz the power, 2016-11-29 06:35:57]

Patchset 4 (id:??) landed as
https://crrev.com/97c594d8353f99139fe51b912991a2a3c097dc26
Cr-Commit-Position: refs/heads/master@{#434912}