Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: runtime/bin/run_vm_tests_fuchsia.cc

Issue 2529293010: Fuchsia: Update VM test statuses (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/run_vm_tests_fuchsia.cc
diff --git a/runtime/bin/run_vm_tests_fuchsia.cc b/runtime/bin/run_vm_tests_fuchsia.cc
index 71cf5c35bb87e5adcfd2a1bb589a648432b5fd31..46e16e6dc2b50512311cef3cab0a4fed6283c1cc 100644
--- a/runtime/bin/run_vm_tests_fuchsia.cc
+++ b/runtime/bin/run_vm_tests_fuchsia.cc
@@ -32,17 +32,9 @@ const char* kSkip[] = {
"Read",
"FileLength",
"FilePosition",
- // Crash in abort() and then hang. (MG-252)
- "ArrayLengthMaxElements",
- "Int8ListLengthMaxElements",
- "ArrayNew_Overflow_Crash",
- "SNPrint_BadArgs",
- "IsolateReload_PendingUnqualifiedCall_InstanceToStatic",
- "IsolateReload_PendingUnqualifiedCall_StaticToInstance",
- "IsolateReload_PendingConstructorCall_AbstractToConcrete",
- "IsolateReload_PendingConstructorCall_ConcreteToAbstract",
- "IsolateReload_PendingStaticCall_DefinedToNSM",
- "IsolateReload_PendingStaticCall_NSMToDefined",
+ // No realpath, files not in image.
+ "Dart2JSCompilerStats",
+ "Dart2JSCompileAll",
// The profiler is turned off.
"Profiler_AllocationSampleTest",
"Profiler_ArrayAllocation",
@@ -69,19 +61,31 @@ const char* kSkip[] = {
"Profiler_TypedArrayAllocation",
"Profiler_GetSourceReport",
"Service_Profile",
- // No realpath, files not in image.
- "Dart2JSCompilerStats",
- "Dart2JSCompileAll",
- // Uses too much memory.
- "PrintJSON",
+};
+
+// Expected to fail/crash.
+const char* kExpectFail[] = {
+ "Fail0",
+ "Fail1",
+ "Fail2",
+ "AllocGeneric_Overflow",
+ "CodeImmutability",
+ "IsolateReload_PendingUnqualifiedCall_StaticToInstance",
+ "IsolateReload_PendingConstructorCall_AbstractToConcrete",
+ "IsolateReload_PendingConstructorCall_ConcreteToAbstract",
+ "IsolateReload_PendingUnqualifiedCall_InstanceToStatic",
+ "IsolateReload_PendingStaticCall_DefinedToNSM",
+ "IsolateReload_PendingStaticCall_NSMToDefined",
+ "ArrayNew_Overflow_Crash",
+ "SNPrint_BadArgs",
+};
+
+// Bugs to fix, or things that are not yet implemented.
+const char* kBugs[] = {
// Need OS::GetCurrentThreadCPUMicros.
- // Skipping because they crash and hang. (MG-252)
- "Timeline_Dart_TimelineGetTrace",
"Timeline_Dart_TimelineGetTraceOnlyDartEvents",
"Timeline_Dart_TimelineGetTraceWithDartEvents",
- "Timeline_Dart_TimelineGetTraceGlobalOverride",
"Timeline_Dart_GlobalTimelineGetTrace",
- "Timeline_Dart_GlobalTimelineGetTrace_Threaded",
"TimelineEventDuration",
"TimelineEventDurationPrintJSON",
"TimelineEventArguments",
@@ -90,24 +94,17 @@ const char* kSkip[] = {
"TimelineAnalysis_ThreadBlockCount",
"TimelineRingRecorderJSONOrder",
"TimelinePauses_BeginEnd",
-};
+ "Timeline_Dart_TimelineGetTrace",
+ "Timeline_Dart_TimelineGetTraceGlobalOverride",
+ "Timeline_Dart_GlobalTimelineGetTrace_Threaded",
+
+ // Need VirtualMemory reservation with mmap.
+ "ArrayLengthMaxElements",
+ "Int8ListLengthMaxElements",
-// Expected to fail/crash.
-const char* kExpectFail[] = {
- "Fail0",
- "Fail1",
- "Fail2",
- "AllocGeneric_Overflow",
- "CodeImmutability",
// Assumes initial thread's stack is the same size as spawned thread stacks.
"StackOverflowStacktraceInfo",
};
-
-// Bugs to fix, or things that are not yet implemented.
-const char* kBugs[] = {
- // Needs read of RSS.
- "InitialRSS",
-};
// clang-format on
static bool contains(const char** list, intptr_t len, const char* str) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698