Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2529293009: Split TrafficPolicer into a generic one-way packet filter class and a policer-specific logic. (Closed)

Created:
4 years ago by Ryan Hamilton
Modified:
4 years ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split TrafficPolicer into a generic one-way packet filter class and a policer-specific logic. The intent here is to be able to create a filter that loses packets based on other patterns (random loss, cyclic loss, etc) without having to write the port-related boilerplate again. n/a (test-only change) Merge internal change: 139945285 BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -67 lines) Patch
M net/net.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A net/quic/test_tools/simulator/packet_filter.h View 1 chunk +77 lines, -0 lines 0 comments Download
A net/quic/test_tools/simulator/packet_filter.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M net/quic/test_tools/simulator/simulator_test.cc View 5 chunks +53 lines, -4 lines 0 comments Download
M net/quic/test_tools/simulator/traffic_policer.h View 4 chunks +5 lines, -27 lines 0 comments Download
M net/quic/test_tools/simulator/traffic_policer.cc View 2 chunks +10 lines, -36 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 3 (1 generated)
Ryan Hamilton
4 years ago (2016-12-01 21:15:15 UTC) #2
Zhongyi Shi
4 years ago (2016-12-01 22:29:30 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698