Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: components/dom_distiller/ios/distiller_favicon_ios.h

Issue 2529283002: Save favicon during reading list distillation (Closed)
Patch Set: Add a comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/ios/distiller_favicon_ios.h
diff --git a/components/dom_distiller/ios/distiller_favicon_ios.h b/components/dom_distiller/ios/distiller_favicon_ios.h
new file mode 100644
index 0000000000000000000000000000000000000000..f58bb026a0764e5c92d7b5b084d4aebd4a8a0944
--- /dev/null
+++ b/components/dom_distiller/ios/distiller_favicon_ios.h
@@ -0,0 +1,27 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_DOM_DISTILLER_IOS_DISTILLER_FAVICON_IOS_H_
+#define COMPONENTS_DOM_DISTILLER_IOS_DISTILLER_FAVICON_IOS_H_
+
+#include <vector>
+
+namespace web {
+struct FaviconURL;
+}
+
+class GURL;
+
+namespace dom_distiller {
+
+class DistillerFaviconIOS {
kkhorimoto 2016/11/28 23:48:25 This needs class comments. Additionally, we only
+ public:
+ // Makes sure the favicons located at |urls| are associated with |page_url|.
+ virtual void HandleFaviconURL(std::vector<web::FaviconURL> urls,
Eugene But (OOO till 7-30) 2016/11/30 18:51:30 Optional nit: Per C+++ Style Guide this should be
+ const GURL& page_url) = 0;
+};
+
+} // namespace dom_distiller
+
+#endif // COMPONENTS_DOM_DISTILLER_IOS_DISTILLER_FAVICON_IOS_H_

Powered by Google App Engine
This is Rietveld 408576698