Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: components/dom_distiller/ios/distiller_page_ios.h

Issue 2529283002: Save favicon during reading list distillation (Closed)
Patch Set: Fix test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/ios/distiller_page_ios.h
diff --git a/components/dom_distiller/ios/distiller_page_ios.h b/components/dom_distiller/ios/distiller_page_ios.h
index 9c799852b91e05c62ddb66aca1555eecaadd07e4..ddd55f31954c92a83aa7b78bcc8dc27b34e64af5 100644
--- a/components/dom_distiller/ios/distiller_page_ios.h
+++ b/components/dom_distiller/ios/distiller_page_ios.h
@@ -10,17 +10,10 @@
#include "base/memory/weak_ptr.h"
#include "components/dom_distiller/core/distiller_page.h"
+#include "components/dom_distiller/ios/favicon_web_state_dispatcher.h"
#include "ios/web/public/web_state/web_state_observer.h"
#include "url/gurl.h"
-namespace ios {
-class WebControllerProvider;
-}
-
-namespace web {
-class BrowserState;
-}
-
namespace dom_distiller {
class DistillerWebStateObserver;
@@ -29,7 +22,7 @@ class DistillerWebStateObserver;
// content.
class DistillerPageIOS : public DistillerPage {
public:
- explicit DistillerPageIOS(web::BrowserState* browser_state);
+ explicit DistillerPageIOS(FaviconWebStateDispatcher* web_state_dispatcher);
~DistillerPageIOS() override;
protected:
@@ -48,10 +41,10 @@ class DistillerPageIOS : public DistillerPage {
// Converts result of WKWebView script evaluation to base::Value
std::unique_ptr<base::Value> ValueResultFromScriptResult(id wk_result);
- web::BrowserState* browser_state_;
GURL url_;
std::string script_;
- std::unique_ptr<ios::WebControllerProvider> provider_;
+ web::WebState* web_state_;
+ FaviconWebStateDispatcher* web_state_dispatcher_;
std::unique_ptr<DistillerWebStateObserver> web_state_observer_;
base::WeakPtrFactory<DistillerPageIOS> weak_ptr_factory_;
};
« no previous file with comments | « components/dom_distiller/ios/distiller_page_factory_ios.mm ('k') | components/dom_distiller/ios/distiller_page_ios.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698