Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(441)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: components/dom_distiller/ios/DEPS
Issue
2529283002
:
Save favicon during reading list distillation (Closed)
Patch Set: Fix test
Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
components/dom_distiller/ios/BUILD.gn
components/dom_distiller/ios/DEPS
components/dom_distiller/ios/distiller_page_factory_ios.h
components/dom_distiller/ios/distiller_page_factory_ios.mm
components/dom_distiller/ios/distiller_page_ios.h
components/dom_distiller/ios/distiller_page_ios.mm
components/dom_distiller/ios/favicon_web_state_dispatcher.h
ios/chrome/browser/dom_distiller/BUILD.gn
ios/chrome/browser/dom_distiller/dom_distiller_service_factory.cc
ios/chrome/browser/dom_distiller/favicon_web_state_dispatcher_impl.h
ios/chrome/browser/dom_distiller/favicon_web_state_dispatcher_impl.mm
ios/chrome/browser/dom_distiller/favicon_web_state_dispatcher_impl_unittest.mm
ios/chrome/test/BUILD.gn
View unified diff
|
Download patch
« no previous file with comments
|
« components/dom_distiller/ios/BUILD.gn
('k') |
components/dom_distiller/ios/distiller_page_factory_ios.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include_rules = [
1 include_rules = [
2
"+ios
/public/provider/web
",
2
"+
components/favicon/
ios",
3 "+ios/web/public",
3 "+ios/web/public",
4 ]
4 ]
OLD
NEW
« no previous file with comments
|
« components/dom_distiller/ios/BUILD.gn
('k') |
components/dom_distiller/ios/distiller_page_factory_ios.h »
('j') |
no next file with comments »
Issue 2529283002: Save favicon during reading list distillation (Closed)
Created 4 years ago by gambard
Modified 4 years ago
Reviewers: Eugene But (OOO till 7-30), kkhorimoto, Olivier, noyau (Ping after 24h), sdefresne
Base URL:
Comments: 146
This is Rietveld
408576698
Chromium Code Reviews
Issue 2529283002:
Save favicon during reading list distillation (Closed)
