Save favicon during reading list distillation

components/dom_distiller/ios/web_state_dispatcher.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_DOM_DISTILLER_IOS_WEB_STATE_DISPATCHER_H_
+#define COMPONENTS_DOM_DISTILLER_IOS_WEB_STATE_DISPATCHER_H_
+
+namespace web {
+class WebState;
+}
+
+namespace dom_distiller {
+
+// Dispatcher for WebState with Favicon Driver attached. The Webstate are kept

[Eugene But (OOO till 7-30), 2016/12/16 15:03:49]

This also attaches HistoryService and BookmarkModel. Please document that.

[gambard, 2016/12/19 09:09:08]

Done.

+// alive between their creation and their return. After a WebState is returned,
+// the dispatcher keeps it alive long enough for it to download the favicons.
+class WebStateDispatcher {

[Eugene But (OOO till 7-30), 2016/12/16 15:03:50]

If offline conversation we determined that there is no good way to make this
class follow Single Responsibility Principle because of the way how
dom_distiller component is designed (and it will too much efforts to refactor
the shared code). Since that's the case could you please include "Favicon" word
in class name. FaviconWebStateDispatcher seems to be a reasonable name.

[gambard, 2016/12/19 09:09:08]

Done.

+ public:
+  WebStateDispatcher() {}
+  virtual ~WebStateDispatcher() {}
+  // Returns a WebState with a Favicon Driver attached.
+  virtual web::WebState* RequestWebState() = 0;
+  // Called to return a WebState. The WebState should not be used after being
+  // returned.
+  virtual void ReturnWebState(web::WebState* web_state) = 0;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(WebStateDispatcher);
+};
+
+}  // namespace dom_distiller
+
+#endif  // COMPONENTS_DOM_DISTILLER_IOS_WEB_STATE_DISPATCHER_H_