ios/chrome/browser/dom_distiller/favicon_observer_factory_impl.mm - Issue 2529283002: Save favicon during reading list distillation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/dom_distiller/favicon_observer_factory_impl.mm

Issue 2529283002: Save favicon during reading list distillation (Closed)

Patch Set: Using web state Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/chrome/browser/dom_distiller/favicon_observer_factory_impl.h ('K') | « ios/chrome/browser/dom_distiller/favicon_observer_factory_impl.h ('k') | ios/chrome/browser/dom_distiller/favicon_observer_factory_impl~.h » ('j') | ios/chrome/browser/dom_distiller/favicon_observer_factory_impl~.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ios/chrome/browser/dom_distiller/favicon_observer_factory_impl.h"

	6

	7 #include "components/favicon/ios/web_favicon_driver.h"

	8 #include "components/keyed_service/core/service_access_type.h"

	9 #include "ios/chrome/browser/bookmarks/bookmark_model_factory.h"

	10 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"

	11 #include "ios/chrome/browser/favicon/favicon_service_factory.h"

	12 #include "ios/chrome/browser/history/history_service_factory.h"

	13 #include "ios/web/public/web_state/web_state.h"
	Eugene But (OOO till 7-30) 2016/12/08 15:34:53 s/include/import s/include/import gambard 2016/12/12 15:04:26 Done. Show quoted text On 2016/12/08 15:34:53, Eugene But wrote: > s/include/import Done.
	14

	15 namespace dom_distiller {

	16

	17 void FaviconObserverFactoryImpl::AddFaviconObserver(

	18 web::WebState* web_state,

	19 web::BrowserState* browser_state) {

	20 ios::ChromeBrowserState* original_browser_state =

	21 ios::ChromeBrowserState::FromBrowserState(browser_state);

	22

	23 favicon::WebFaviconDriver::CreateForWebState(

	24 web_state,

	25 ios::FaviconServiceFactory::GetForBrowserState(

	26 original_browser_state, ServiceAccessType::EXPLICIT_ACCESS),

	27 ios::HistoryServiceFactory::GetForBrowserState(

	28 original_browser_state, ServiceAccessType::EXPLICIT_ACCESS),

	29 ios::BookmarkModelFactory::GetForBrowserState(original_browser_state));

	30 }

	31 }
	Eugene But (OOO till 7-30) 2016/12/08 15:34:53 // namespace dom_distiller // namespace dom_distiller gambard 2016/12/12 15:04:26 Done. Show quoted text On 2016/12/08 15:34:53, Eugene But wrote: > // namespace dom_distiller Done.
OLD	NEW