Save favicon during reading list distillation

components/dom_distiller/ios/distiller_page_ios.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DOM_DISTILLER_IOS_DISTILLER_PAGE_IOS_H_
 #define COMPONENTS_DOM_DISTILLER_IOS_DISTILLER_PAGE_IOS_H_
 
 #include <memory>
 #include <string>
 
 #include "base/memory/weak_ptr.h"
 #include "components/dom_distiller/core/distiller_page.h"
 #include "ios/web/public/web_state/web_state_observer.h"
 #include "url/gurl.h"
 
-namespace ios {
-class WebControllerProvider;
-}
-
 namespace web {
-class BrowserState;
+class WebState;
 }
 
 namespace dom_distiller {
 
 class DistillerWebStateObserver;
 
 // Loads URLs and injects JavaScript into a page, extracting the distilled page
 // content.
 class DistillerPageIOS : public DistillerPage {

[Olivier, 2016/12/08 18:28:02]

May be you can implement FaviconDriverObserver here.
That way you will have a OnFaviconUpdated call.

[gambard, 2016/12/12 15:04:26]

Acknowledged.

  public:
-  explicit DistillerPageIOS(web::BrowserState* browser_state);
+  explicit DistillerPageIOS(web::WebState* web_state);
   ~DistillerPageIOS() override;
+  void test(const base::Value*);

[Eugene But (OOO till 7-30), 2016/12/08 15:34:53]

I guess this was added for testing or something.

[gambard, 2016/12/12 15:04:26]

Done.

 
  protected:
   bool StringifyOutput() override;
   void DistillPageImpl(const GURL& url, const std::string& script) override;
 
  private:
   friend class DistillerWebStateObserver;
 
   // Called by |web_state_observer_| once the page has finished loading.
   void OnLoadURLDone(web::PageLoadCompletionStatus load_completion_status);
 
   // Called once the |script_| has been evaluated on the page.
   void HandleJavaScriptResult(id result);
 
   // Converts result of WKWebView script evaluation to base::Value
   std::unique_ptr<base::Value> ValueResultFromScriptResult(id wk_result);
 
-  web::BrowserState* browser_state_;
   GURL url_;
   std::string script_;
-  std::unique_ptr<ios::WebControllerProvider> provider_;
+  web::WebState* web_state_;
   std::unique_ptr<DistillerWebStateObserver> web_state_observer_;
   base::WeakPtrFactory<DistillerPageIOS> weak_ptr_factory_;
 };
 
 }  // namespace dom_distiller
 
 #endif  // COMPONENTS_DOM_DISTILLER_IOS_DISTILLER_PAGE_IOS_H_