Move passing of WebRTC rendering frames to IO thread

content/renderer/media/media_stream_video_renderer_sink_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/child/child_process.h"
 #include "content/renderer/media/media_stream_video_renderer_sink.h"
@@ skipping 37 matching lines @@
         true);
     mock_source_->StartMockedSource();
     base::RunLoop().RunUntilIdle();
 
     media_stream_video_renderer_sink_ = new MediaStreamVideoRendererSink(
         blink_track_,
         base::Bind(&MediaStreamVideoRendererSinkTest::ErrorCallback,
                    base::Unretained(this)),
         base::Bind(&MediaStreamVideoRendererSinkTest::RepaintCallback,
                    base::Unretained(this)),
-        message_loop_.task_runner(), message_loop_.task_runner(),
+        child_process_->io_task_runner(), message_loop_.task_runner(),
         message_loop_.task_runner(), nullptr /* gpu_factories */);
     base::RunLoop().RunUntilIdle();
 
     EXPECT_TRUE(IsInStoppedState());
   }
 
   void TearDown() override {
     media_stream_video_renderer_sink_ = nullptr;
     blink_source_.reset();
     blink_track_.reset();
     blink::WebHeap::collectAllGarbageForTesting();
 
     // Let the message loop run to finish destroying the pool.
     base::RunLoop().RunUntilIdle();
   }
 
   MOCK_METHOD1(RepaintCallback, void(scoped_refptr<media::VideoFrame>));
   MOCK_METHOD0(ErrorCallback, void(void));
 
   bool IsInStartedState() const {
+    RunIOUntilIdle();
     return media_stream_video_renderer_sink_->GetStateForTesting() ==
            MediaStreamVideoRendererSink::STARTED;
   }
   bool IsInStoppedState() const {
+    RunIOUntilIdle();
     return media_stream_video_renderer_sink_->GetStateForTesting() ==
            MediaStreamVideoRendererSink::STOPPED;
   }
   bool IsInPausedState() const {
+    RunIOUntilIdle();
     return media_stream_video_renderer_sink_->GetStateForTesting() ==
            MediaStreamVideoRendererSink::PAUSED;
   }
 
   void OnVideoFrame(scoped_refptr<media::VideoFrame> frame) {
     mock_source_->DeliverVideoFrame(frame);
     base::RunLoop().RunUntilIdle();
 
-    // |blink_track_| uses IO thread to send frames to sinks. Make sure that
-    // tasks on IO thread are completed before moving on.
-    base::RunLoop run_loop;
-    child_process_->io_task_runner()->PostTaskAndReply(
-        FROM_HERE, base::Bind([] {}), run_loop.QuitClosure());
-    run_loop.Run();
-    base::RunLoop().RunUntilIdle();
+    RunIOUntilIdle();
   }
 
   void SetGpuMemoryBufferVideoForTesting(
       media::GpuMemoryBufferVideoFramePool* gpu_memory_buffer_pool) {
     media_stream_video_renderer_sink_->SetGpuMemoryBufferVideoForTesting(
         gpu_memory_buffer_pool);
   }
 
   scoped_refptr<MediaStreamVideoRendererSink> media_stream_video_renderer_sink_;
 
  protected:
   // A ChildProcess and a MessageLoopForUI are both needed to fool the Tracks
   // and Sources in |registry_| into believing they are on the right threads.
   base::MessageLoopForUI message_loop_;
   const std::unique_ptr<ChildProcess> child_process_;
 
   blink::WebMediaStreamTrack blink_track_;
 
  private:
+  void RunIOUntilIdle() const {
+    // |blink_track_| uses IO thread to send frames to sinks. Make sure that
+    // tasks on IO thread are completed before moving on.
+    base::RunLoop run_loop;
+    child_process_->io_task_runner()->PostTaskAndReply(
+        FROM_HERE, base::Bind([] {}), run_loop.QuitClosure());
+    run_loop.Run();
+    base::RunLoop().RunUntilIdle();
+  }
+
   blink::WebMediaStreamSource blink_source_;
   MockMediaStreamVideoSource* mock_source_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaStreamVideoRendererSinkTest);
 };
 
 // Checks that the initialization-destruction sequence works fine.
 TEST_F(MediaStreamVideoRendererSinkTest, StartStop) {
   EXPECT_TRUE(IsInStoppedState());
 
   media_stream_video_renderer_sink_->Start();
-  base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(IsInStartedState());
 
   media_stream_video_renderer_sink_->Pause();
-  base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(IsInPausedState());
 
   media_stream_video_renderer_sink_->Resume();
-  base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(IsInStartedState());
 
   media_stream_video_renderer_sink_->Stop();
-  base::RunLoop().RunUntilIdle();
   EXPECT_TRUE(IsInStoppedState());
 }
 
 // Sends 2 frames and expect them as WebM contained encoded data in writeData().
 TEST_F(MediaStreamVideoRendererSinkTest, EncodeVideoFrames) {
   media_stream_video_renderer_sink_->Start();
 
   InSequence s;
   const scoped_refptr<media::VideoFrame> video_frame =
       media::VideoFrame::CreateBlackFrame(gfx::Size(160, 80));
@@ skipping 37 matching lines @@
     : public MediaStreamVideoRendererSinkTest {
  public:
   MediaStreamVideoRendererSinkTransparencyTest() {
     media_stream_video_renderer_sink_ = new MediaStreamVideoRendererSink(
         blink_track_,
         base::Bind(&MediaStreamVideoRendererSinkTest::ErrorCallback,
                    base::Unretained(this)),
         base::Bind(&MediaStreamVideoRendererSinkTransparencyTest::
                        VerifyTransparentFrame,
                    base::Unretained(this)),
-        message_loop_.task_runner(), message_loop_.task_runner(),
+        child_process_->io_task_runner(), message_loop_.task_runner(),
         message_loop_.task_runner(), nullptr /* gpu_factories */);
   }
 
   void VerifyTransparentFrame(scoped_refptr<media::VideoFrame> frame) {
     EXPECT_EQ(media::PIXEL_FORMAT_YV12A, frame->format());
   }
 };
 
 TEST_F(MediaStreamVideoRendererSinkTransparencyTest,
        SendTransparentFrame) {
   media_stream_video_renderer_sink_->Start();
 
   InSequence s;
   const gfx::Size kSize(10, 10);
   const base::TimeDelta kTimestamp = base::TimeDelta();
   const scoped_refptr<media::VideoFrame> video_frame =
       media::VideoFrame::CreateFrame(media::PIXEL_FORMAT_YV12A, kSize,
                                      gfx::Rect(kSize), kSize, kTimestamp);
   OnVideoFrame(video_frame);
   base::RunLoop().RunUntilIdle();
 
   media_stream_video_renderer_sink_->Stop();
 }
 
 }  // namespace content