Skip leading space in ltr text in rtl flow when placing ellipsis

Skip leading space in ltr text in rtl flow when placing ellipsis

Account for leading space when selecting our offset for the visible text.

BUG=667128
Committed: https://crrev.com/77dd2d44c88d51cbda3d2fcf35c7153b16f652e4
Cr-Commit-Position: refs/heads/master@{#436216}

[rhogan, 2016-11-27 23:00:51]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-27 23:00:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 00:27:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 00:27:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rhogan, 2016-11-28 19:50:13]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 19:51:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 21:49:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 21:49:02]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rhogan, 2016-11-28 22:24:52]

Description was changed from

==========
Use the box width for placing the ellipsis

BUG=667128
==========

to

==========
Skip leading space in ltr text in rtl flow when placing ellipsis

Account for leading space when selecting our offset for the visible text.

BUG=667128
==========

[rhogan, 2016-11-29 14:42:15]

robhogan@gmail.com changed reviewers:
+ eae@chromium.org, kojii@chromium.org

[rhogan, 2016-11-30 21:37:24]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 21:37:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 22:53:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 22:53:11]

Dry run: This issue passed the CQ dry run.

[rhogan, 2016-12-01 19:12:43]

robhogan@gmail.com changed reviewers:
+ pdr@chromium.org

[rhogan, 2016-12-01 19:12:44]

pdr/kojii - who is my line layout person in eae's absence?

[pdr., 2016-12-01 19:37:09]

pdr@chromium.org changed reviewers:
+ szager@chromium.org

[pdr., 2016-12-01 19:37:56]

On 2016/12/01 at 19:12:44, robhogan wrote:
> pdr/kojii - who is my line layout person in eae's absence?

+szager

Stefan, can you review this?

[kojii, 2016-12-02 07:51:52]

Ah, right, InlineTextBox has offsets after whitespaces are collapsed so we don't
have to worry about that.

Great catch of this error, I'm so glad our ellipsis is getting better and
better, thank you for your continued work on this.

non-owner LGTM.

[kojii, 2016-12-02 08:23:27]

(sorry I don't know who can review inline layout, other then eae and Levi...hope
Stefan can)

[eae, 2016-12-02 10:21:09]

This is great!

drott and szager are probably your best bet in my absence. I'm in UTC+1 this
week and not out though :)

[eae, 2016-12-02 10:21:14]

LGTM

[rhogan, 2016-12-02 10:23:59]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2016-12-02 10:24:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 11:57:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 11:57:17]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:450
  error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
b08a5600071595c6a590058c147d63a74c494372..2d02658e57018e58fcb28505c28ec06fc6bc2681
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -450,6 +450,12 @@ crbug.com/518993
imported/wpt/user-timing/test_user_timing_measure_navigation_ti
 crbug.com/636053 [ Mac Win ]
printing/thead-repeats-at-top-of-each-page-multiple-tables.html [
NeedsManualRebaseline ]
 crbug.com/636053 [ Mac Win ]
virtual/threaded/printing/thead-repeats-at-top-of-each-page-multiple-tables.html
[ NeedsManualRebaseline ]
 
+crbug.com/667128 [ Mac Win ]
editing/selection/select-text-overflow-ellipsis-mixed-in-ltr.html [
NeedsRebaseline ]
+crbug.com/667128 [ Mac Win ] fast/css/text-overflow-ellipsis-strict.html [
NeedsRebaseline ]
+crbug.com/667128 [ Mac Win ] fast/css/text-overflow-ellipsis.html [
NeedsRebaseline ]
+crbug.com/667128 [ Mac Win ]
fast/text/ellipsis-ltr-text-in-rtl-flow-leading-space.html [ NeedsRebaseline ]
+crbug.com/667128 [ Mac Win ]
fast/text/ellipsis-mixed-text-in-ltr-flow-underline.html [ NeedsRebaseline ]
+
 crbug.com/636239 [ Win7 ] media/video-zoom-controls.html [ Failure ]
 crbug.com/520189 [ Mac ] http/tests/misc/submit-post-keygen.html [ Pass Timeout
]

[rhogan, 2016-12-02 18:58:00]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2016-12-02 18:58:01]

The patchset sent to the CQ was uploaded after l-g-t-m from kojii@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2529243002/#ps80001
(title: "bug 667128")

[commit-bot: I haz the power, 2016-12-02 18:58:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 22:23:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 22:23:50]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:526
  error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
b08a5600071595c6a590058c147d63a74c494372..3c5a0bcd3c89b2dc51f1fef30218517b4601c91a
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -526,6 +526,12 @@ crbug.com/596968 [ Win ]
inspector-protocol/input/eventTimestamp.html [ Failure
 crbug.com/248938 [ Win Debug ]
virtual/threaded/animations/transition-and-animation-2.html [ Timeout ]
 crbug.com/487281 [ Mac ] fast/forms/select/menulist-narrow-width.html [ Failure
]
 
+crbug.com/667128 [ Mac Win ]
editing/selection/select-text-overflow-ellipsis-mixed-in-ltr.html [
NeedsRebaseline ]
+crbug.com/667128 [ Mac Win ] fast/css/text-overflow-ellipsis-strict.html [
NeedsRebaseline ]
+crbug.com/667128 [ Mac Win ] fast/css/text-overflow-ellipsis.html [
NeedsRebaseline ]
+crbug.com/667128 [ Mac Win ]
fast/text/ellipsis-ltr-text-in-rtl-flow-leading-space.html [ NeedsRebaseline ]
+crbug.com/667128 [ Mac Win ]
fast/text/ellipsis-mixed-text-in-ltr-flow-underline.html [ NeedsRebaseline ]
+
 crbug.com/543110 [ Mac ] fast/text/international/text-shaping-arabic.html [
Failure ]
 
 # This directly has manual tests that don't have to run with run-webkit-tests

[rhogan, 2016-12-03 11:43:11]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2016-12-03 11:43:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 21:12:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-03 21:12:05]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:526
  error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
b08a5600071595c6a590058c147d63a74c494372..3c5a0bcd3c89b2dc51f1fef30218517b4601c91a
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -526,6 +526,12 @@ crbug.com/596968 [ Win ]
inspector-protocol/input/eventTimestamp.html [ Failure
 crbug.com/248938 [ Win Debug ]
virtual/threaded/animations/transition-and-animation-2.html [ Timeout ]
 crbug.com/487281 [ Mac ] fast/forms/select/menulist-narrow-width.html [ Failure
]
 
+crbug.com/667128 [ Mac Win ]
editing/selection/select-text-overflow-ellipsis-mixed-in-ltr.html [
NeedsRebaseline ]
+crbug.com/667128 [ Mac Win ] fast/css/text-overflow-ellipsis-strict.html [
NeedsRebaseline ]
+crbug.com/667128 [ Mac Win ] fast/css/text-overflow-ellipsis.html [
NeedsRebaseline ]
+crbug.com/667128 [ Mac Win ]
fast/text/ellipsis-ltr-text-in-rtl-flow-leading-space.html [ NeedsRebaseline ]
+crbug.com/667128 [ Mac Win ]
fast/text/ellipsis-mixed-text-in-ltr-flow-underline.html [ NeedsRebaseline ]
+
 crbug.com/543110 [ Mac ] fast/text/international/text-shaping-arabic.html [
Failure ]
 
 # This directly has manual tests that don't have to run with run-webkit-tests

[rhogan, 2016-12-04 14:07:53]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2016-12-04 14:08:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-04 16:21:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-04 16:21:52]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:526
  error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
b08a5600071595c6a590058c147d63a74c494372..3c5a0bcd3c89b2dc51f1fef30218517b4601c91a
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -526,6 +526,12 @@ crbug.com/596968 [ Win ]
inspector-protocol/input/eventTimestamp.html [ Failure
 crbug.com/248938 [ Win Debug ]
virtual/threaded/animations/transition-and-animation-2.html [ Timeout ]
 crbug.com/487281 [ Mac ] fast/forms/select/menulist-narrow-width.html [ Failure
]
 
+crbug.com/667128 [ Mac Win ]
editing/selection/select-text-overflow-ellipsis-mixed-in-ltr.html [
NeedsRebaseline ]
+crbug.com/667128 [ Mac Win ] fast/css/text-overflow-ellipsis-strict.html [
NeedsRebaseline ]
+crbug.com/667128 [ Mac Win ] fast/css/text-overflow-ellipsis.html [
NeedsRebaseline ]
+crbug.com/667128 [ Mac Win ]
fast/text/ellipsis-ltr-text-in-rtl-flow-leading-space.html [ NeedsRebaseline ]
+crbug.com/667128 [ Mac Win ]
fast/text/ellipsis-mixed-text-in-ltr-flow-underline.html [ NeedsRebaseline ]
+
 crbug.com/543110 [ Mac ] fast/text/international/text-shaping-arabic.html [
Failure ]
 
 # This directly has manual tests that don't have to run with run-webkit-tests

[rhogan, 2016-12-04 21:51:13]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[rhogan, 2016-12-04 21:51:22]

The CQ bit was unchecked by robhogan@gmail.com

[rhogan, 2016-12-04 21:51:26]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2016-12-04 21:51:26]

The patchset sent to the CQ was uploaded after l-g-t-m from kojii@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2529243002/#ps100001
(title: "bug 667128")

[commit-bot: I haz the power, 2016-12-04 21:51:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 01:47:39]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480888286434380,
"parent_rev": "4af86156834866f9bd82ec9bb555c720a923e2b5", "commit_rev":
"0b78b3a46d6ca186d51af946ca44fd7ca95ce3dd"}

[commit-bot: I haz the power, 2016-12-05 01:48:28]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-05 01:52:21]

Description was changed from

==========
Skip leading space in ltr text in rtl flow when placing ellipsis

Account for leading space when selecting our offset for the visible text.

BUG=667128
==========

to

==========
Skip leading space in ltr text in rtl flow when placing ellipsis

Account for leading space when selecting our offset for the visible text.

BUG=667128

Committed: https://crrev.com/77dd2d44c88d51cbda3d2fcf35c7153b16f652e4
Cr-Commit-Position: refs/heads/master@{#436216}
==========

[commit-bot: I haz the power, 2016-12-05 01:52:23]

Patchset 6 (id:??) landed as
https://crrev.com/77dd2d44c88d51cbda3d2fcf35c7153b16f652e4
Cr-Commit-Position: refs/heads/master@{#436216}