Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2529233002: [turbofan] Add more typing rules for Array.prototype builtins. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add more typing rules for Array.prototype builtins. For a couple of those Array builtins we can specify a useful type that will help us to eliminate a couple of checks on their outputs. R=yangguo@chromium.org BUG=v8:5267 Committed: https://crrev.com/ffdf47495698e850e5bf1f71d4212a4461088cf6 Cr-Commit-Position: refs/heads/master@{#41295}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
M src/compiler/typer.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +15 lines, -1 line 2 comments Download

Messages

Total messages: 14 (7 generated)
Benedikt Meurer
4 years ago (2016-11-27 19:37:16 UTC) #1
Benedikt Meurer
Hey Yang, Here's a follow-up CL for Array builtin types. Please take a look. Thanks, ...
4 years ago (2016-11-27 19:37:45 UTC) #4
Yang
lgtm https://codereview.chromium.org/2529233002/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/2529233002/diff/1/src/objects.h#newcode7230 src/objects.h:7230: #define FUNCTIONS_WITH_ID_LIST(V) \ We should move this to ...
4 years ago (2016-11-28 07:58:11 UTC) #7
Benedikt Meurer
https://codereview.chromium.org/2529233002/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/2529233002/diff/1/src/objects.h#newcode7230 src/objects.h:7230: #define FUNCTIONS_WITH_ID_LIST(V) \ I'd rather stick to the plan ...
4 years ago (2016-11-28 07:59:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529233002/1
4 years ago (2016-11-28 07:59:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 08:00:59 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-28 08:01:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffdf47495698e850e5bf1f71d4212a4461088cf6
Cr-Commit-Position: refs/heads/master@{#41295}

Powered by Google App Engine
This is Rietveld 408576698