Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: media/cast/transport/cast_transport_config.cc

Issue 252923007: Cast: Fix two video freezing problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: hide max outstanding frames from cast library users Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/cast/transport/cast_transport_config.h" 5 #include "media/cast/transport/cast_transport_config.h"
6 6
7 namespace media { 7 namespace media {
8 namespace cast { 8 namespace cast {
9 namespace transport { 9 namespace transport {
10 10
11 namespace { 11 namespace {
12 const int kDefaultRtpHistoryMs = 1000; 12 const int kDefaultRtpHistoryMs = 1000;
13 const int kDefaultRtpMaxDelayMs = 100; 13 const int kDefaultRtpMaxDelayMs = 100;
14 } // namespace 14 } // namespace
15 15
16 RtpConfig::RtpConfig() 16 RtpConfig::RtpConfig()
17 : history_ms(kDefaultRtpHistoryMs), 17 : ssrc(0),
18 max_delay_ms(kDefaultRtpMaxDelayMs), 18 max_delay_ms(kDefaultRtpMaxDelayMs),
19 payload_type(0) {} 19 payload_type(0) {}
20 20
21 CastTransportBaseConfig::CastTransportBaseConfig() 21 RtpConfig::~RtpConfig() {}
22 : ssrc(0) {}
23 22
24 CastTransportBaseConfig::~CastTransportBaseConfig() {} 23 TransportRtpConfig::TransportRtpConfig()
24 : max_outstanding_frames(-1) {}
Alpha Left Google 2014/04/29 00:55:05 Why not just 0?
hubbe 2014/04/29 17:19:58 Because I want it to be an error to not set this.
25
26 TransportRtpConfig::~TransportRtpConfig() {}
25 27
26 CastTransportAudioConfig::CastTransportAudioConfig() 28 CastTransportAudioConfig::CastTransportAudioConfig()
27 : codec(kOpus), frequency(0), channels(0) {} 29 : codec(kOpus), frequency(0), channels(0) {}
28 30
29 CastTransportAudioConfig::~CastTransportAudioConfig() {} 31 CastTransportAudioConfig::~CastTransportAudioConfig() {}
30 32
31 CastTransportVideoConfig::CastTransportVideoConfig() : codec(kVp8) {} 33 CastTransportVideoConfig::CastTransportVideoConfig() : codec(kVp8) {}
32 34
33 CastTransportVideoConfig::~CastTransportVideoConfig() {} 35 CastTransportVideoConfig::~CastTransportVideoConfig() {}
34 36
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 : last_rr(0), delay_since_last_rr(0) {} 73 : last_rr(0), delay_since_last_rr(0) {}
72 RtcpDlrrReportBlock::~RtcpDlrrReportBlock() {} 74 RtcpDlrrReportBlock::~RtcpDlrrReportBlock() {}
73 75
74 SendRtcpFromRtpSenderData::SendRtcpFromRtpSenderData() 76 SendRtcpFromRtpSenderData::SendRtcpFromRtpSenderData()
75 : packet_type_flags(0), sending_ssrc(0) {} 77 : packet_type_flags(0), sending_ssrc(0) {}
76 SendRtcpFromRtpSenderData::~SendRtcpFromRtpSenderData() {} 78 SendRtcpFromRtpSenderData::~SendRtcpFromRtpSenderData() {}
77 79
78 } // namespace transport 80 } // namespace transport
79 } // namespace cast 81 } // namespace cast
80 } // namespace media 82 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698