Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: extensions/renderer/messaging_bindings.cc

Issue 2529213002: Delete TODO-comment about guest process/frame IDs in MessageService::OpenChannelImpl (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/messaging_bindings.cc
diff --git a/extensions/renderer/messaging_bindings.cc b/extensions/renderer/messaging_bindings.cc
index b82e84b113e571242a45d951dc5e0db6c9fb67e4..c8ad89387a7a1894a742ef890ce7620671cf25b0 100644
--- a/extensions/renderer/messaging_bindings.cc
+++ b/extensions/renderer/messaging_bindings.cc
@@ -75,6 +75,11 @@ void DispatchOnConnectToScriptContext(
const std::string& tls_channel_id,
bool* port_created,
ScriptContext* script_context) {
+ if (info.source_is_in_same_process &&
+ info.source_render_frame_routing_id ==
+ script_context->GetRenderFrame()->GetRoutingID())
+ return;
+
MessagingBindings* bindings = g_messaging_map.Get()[script_context];
DCHECK(bindings);
@@ -122,7 +127,7 @@ void DispatchOnConnectToScriptContext(
if (info.guest_process_id != content::ChildProcessHost::kInvalidUniqueID) {
guest_process_id = v8::Integer::New(isolate, info.guest_process_id);
guest_render_frame_routing_id =
- v8::Integer::New(isolate, info.guest_render_frame_routing_id);
+ v8::Integer::New(isolate, info.source_render_frame_routing_id);
}
}

Powered by Google App Engine
This is Rietveld 408576698