Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: chrome/browser/extensions/api/messaging/message_service.h

Issue 2529213002: Delete TODO-comment about guest process/frame IDs in MessageService::OpenChannelImpl (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_MESSAGING_MESSAGE_SERVICE_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_MESSAGING_MESSAGE_SERVICE_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_MESSAGING_MESSAGE_SERVICE_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_MESSAGING_MESSAGE_SERVICE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <set> 10 #include <set>
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 74
75 // Called right before a port is connected to a channel. If false, the port 75 // Called right before a port is connected to a channel. If false, the port
76 // is not used and the channel is closed. 76 // is not used and the channel is closed.
77 virtual bool IsValidPort() = 0; 77 virtual bool IsValidPort() = 0;
78 78
79 // Notify the port that the channel has been opened. 79 // Notify the port that the channel has been opened.
80 virtual void DispatchOnConnect( 80 virtual void DispatchOnConnect(
81 const std::string& channel_name, 81 const std::string& channel_name,
82 std::unique_ptr<base::DictionaryValue> source_tab, 82 std::unique_ptr<base::DictionaryValue> source_tab,
83 int source_frame_id, 83 int source_frame_id,
84 int guest_process_id, 84 bool include_guest_process_info,
85 int guest_render_frame_routing_id, 85 int source_process_id,
86 int source_render_frame_routing_id,
86 const std::string& source_extension_id, 87 const std::string& source_extension_id,
87 const std::string& target_extension_id, 88 const std::string& target_extension_id,
88 const GURL& source_url, 89 const GURL& source_url,
89 const std::string& tls_channel_id) {} 90 const std::string& tls_channel_id) {}
90 91
91 // Notify the port that the channel has been closed. If |error_message| is 92 // Notify the port that the channel has been closed. If |error_message| is
92 // non-empty, it indicates an error occurred while opening the connection. 93 // non-empty, it indicates an error occurred while opening the connection.
93 virtual void DispatchOnDisconnect(const std::string& error_message) {} 94 virtual void DispatchOnDisconnect(const std::string& error_message) {}
94 95
95 // Dispatch a message to this end of the communication. 96 // Dispatch a message to this end of the communication.
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 LazyBackgroundTaskQueue* lazy_background_task_queue_; 317 LazyBackgroundTaskQueue* lazy_background_task_queue_;
317 318
318 base::WeakPtrFactory<MessageService> weak_factory_; 319 base::WeakPtrFactory<MessageService> weak_factory_;
319 320
320 DISALLOW_COPY_AND_ASSIGN(MessageService); 321 DISALLOW_COPY_AND_ASSIGN(MessageService);
321 }; 322 };
322 323
323 } // namespace extensions 324 } // namespace extensions
324 325
325 #endif // CHROME_BROWSER_EXTENSIONS_API_MESSAGING_MESSAGE_SERVICE_H_ 326 #endif // CHROME_BROWSER_EXTENSIONS_API_MESSAGING_MESSAGE_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698