Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: chrome/browser/extensions/api/messaging/extension_message_port.h

Issue 2529213002: Delete TODO-comment about guest process/frame IDs in MessageService::OpenChannelImpl (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_MESSAGING_EXTENSION_MESSAGE_PORT_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_MESSAGING_EXTENSION_MESSAGE_PORT_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_MESSAGING_EXTENSION_MESSAGE_PORT_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_MESSAGING_EXTENSION_MESSAGE_PORT_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "chrome/browser/extensions/api/messaging/message_service.h" 9 #include "chrome/browser/extensions/api/messaging/message_service.h"
10 10
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 // ports because the frame may be navigated before the port was initialized. 47 // ports because the frame may be navigated before the port was initialized.
48 void RevalidatePort(); 48 void RevalidatePort();
49 49
50 // MessageService::MessagePort: 50 // MessageService::MessagePort:
51 void RemoveCommonFrames(const MessagePort& port) override; 51 void RemoveCommonFrames(const MessagePort& port) override;
52 bool HasFrame(content::RenderFrameHost* rfh) const override; 52 bool HasFrame(content::RenderFrameHost* rfh) const override;
53 bool IsValidPort() override; 53 bool IsValidPort() override;
54 void DispatchOnConnect(const std::string& channel_name, 54 void DispatchOnConnect(const std::string& channel_name,
55 std::unique_ptr<base::DictionaryValue> source_tab, 55 std::unique_ptr<base::DictionaryValue> source_tab,
56 int source_frame_id, 56 int source_frame_id,
57 int guest_process_id, 57 bool include_guest_process_info,
58 int guest_render_frame_routing_id, 58 int source_process_id,
59 int source_render_frame_routing_id,
59 const std::string& source_extension_id, 60 const std::string& source_extension_id,
60 const std::string& target_extension_id, 61 const std::string& target_extension_id,
61 const GURL& source_url, 62 const GURL& source_url,
62 const std::string& tls_channel_id) override; 63 const std::string& tls_channel_id) override;
63 void DispatchOnDisconnect(const std::string& error_message) override; 64 void DispatchOnDisconnect(const std::string& error_message) override;
64 void DispatchOnMessage(const Message& message) override; 65 void DispatchOnMessage(const Message& message) override;
65 void IncrementLazyKeepaliveCount() override; 66 void IncrementLazyKeepaliveCount() override;
66 void DecrementLazyKeepaliveCount() override; 67 void DecrementLazyKeepaliveCount() override;
67 void OpenPort(int process_id, int routing_id) override; 68 void OpenPort(int process_id, int routing_id) override;
68 void ClosePort(int process_id, int routing_id) override; 69 void ClosePort(int process_id, int routing_id) override;
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 111
111 ExtensionHost* background_host_ptr_; // used in IncrementLazyKeepaliveCount 112 ExtensionHost* background_host_ptr_; // used in IncrementLazyKeepaliveCount
112 std::unique_ptr<FrameTracker> frame_tracker_; 113 std::unique_ptr<FrameTracker> frame_tracker_;
113 114
114 DISALLOW_COPY_AND_ASSIGN(ExtensionMessagePort); 115 DISALLOW_COPY_AND_ASSIGN(ExtensionMessagePort);
115 }; 116 };
116 117
117 } // namespace extensions 118 } // namespace extensions
118 119
119 #endif // CHROME_BROWSER_EXTENSIONS_API_MESSAGING_EXTENSION_MESSAGE_PORT_H_ 120 #endif // CHROME_BROWSER_EXTENSIONS_API_MESSAGING_EXTENSION_MESSAGE_PORT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698