Delete TODO-comment about guest process/frame IDs in MessageService::OpenChannelImpl

chrome/browser/extensions/api/messaging/extension_message_port.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/messaging/extension_message_port.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/scoped_observer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/interstitial_page.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
+#include "content/public/common/child_process_host.h"
 #include "extensions/browser/extension_host.h"
 #include "extensions/browser/process_manager.h"
 #include "extensions/browser/process_manager_observer.h"
 #include "extensions/common/extension_messages.h"
 #include "extensions/common/manifest_handlers/background_info.h"
 
 namespace extensions {
 
 const char kReceivingEndDoesntExistError[] =
     "Could not establish connection. Receiving end does not exist.";
@@ skipping 163 matching lines @@
 }
 
 bool ExtensionMessagePort::IsValidPort() {
   return !frames_.empty();
 }
 
 void ExtensionMessagePort::DispatchOnConnect(
     const std::string& channel_name,
     std::unique_ptr<base::DictionaryValue> source_tab,
     int source_frame_id,
-    int guest_process_id,
-    int guest_render_frame_routing_id,
+    bool include_guest_process_info,
+    int source_process_id,
+    int source_render_frame_routing_id,
     const std::string& source_extension_id,
     const std::string& target_extension_id,
     const GURL& source_url,
     const std::string& tls_channel_id) {
   ExtensionMsg_TabConnectionInfo source;
   if (source_tab) {
     source.tab.Swap(source_tab.get());
     source.tab.GetInteger("id", &opener_tab_id_);
   }
   source.frame_id = source_frame_id;
 
   ExtensionMsg_ExternalConnectionInfo info;
   info.target_id = target_extension_id;
   info.source_id = source_extension_id;
   info.source_url = source_url;
-  info.guest_process_id = guest_process_id;
-  info.guest_render_frame_routing_id = guest_render_frame_routing_id;
+  info.guest_process_id = include_guest_process_info

[dcheng, 2016/11/27 01:08:18]

I thought we try not to plumb process ID information from browser to renderer...
I guess it's unavoidable here due to the api exposed by extensions.

+                              ? source_process_id
+                              : content::ChildProcessHost::kInvalidUniqueID;
+  info.source_render_frame_routing_id = source_render_frame_routing_id;
+  // As an optimization, SendToPort will broadcast messages targeting extensions
+  // to the extension process instead of its individual frames. As a result, if
+  // the sender is also in the extension process, it will also be notified. This
+  // flag (together with |source_render_frame_routing_id|) is used to avoid
+  // unnecessarily dispatching onConnect to the sending frame in this case.
+  info.source_is_in_same_process =
+      extension_process_ && extension_process_->GetID() == source_process_id;
 
   SendToPort(base::MakeUnique<ExtensionMsg_DispatchOnConnect>(
       MSG_ROUTING_NONE, port_id_, channel_name, source, info, tls_channel_id));
 }
 
 void ExtensionMessagePort::DispatchOnDisconnect(
     const std::string& error_message) {
   SendToPort(base::MakeUnique<ExtensionMsg_DispatchOnDisconnect>(
       MSG_ROUTING_NONE, port_id_, error_message));
 }
@@ skipping 76 matching lines @@
     return;
   }
   for (content::RenderFrameHost* rfh : frames_) {
     IPC::Message* msg_copy = new IPC::Message(*msg);
     msg_copy->set_routing_id(rfh->GetRoutingID());
     rfh->Send(msg_copy);
   }
 }
 
 }  // namespace extensions