Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2529203002: [ios] Adds signin resources and styled text fields to ChromiumBrowserProvider. (Closed)

Created:
4 years ago by rohitrao (ping after 24h)
Modified:
4 years ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds signin resources and styled text fields to ChromiumBrowserProvider. These additions prevent crashes when running the signin tests and when trying to edit a bookmark. BUG=666375 Committed: https://crrev.com/09fd6245fae38d10caa8cff99d777b95f22b909a Cr-Commit-Position: refs/heads/master@{#434649}

Patch Set 1 #

Patch Set 2 : Use utility method. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -2 lines) Patch
M ios/chrome/browser/providers/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/providers/chromium_browser_provider.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/providers/chromium_browser_provider.mm View 3 chunks +8 lines, -2 lines 0 comments Download
A ios/chrome/browser/providers/signin/BUILD.gn View 1 1 chunk +17 lines, -0 lines 0 comments Download
A ios/chrome/browser/providers/signin/chromium_signin_resources_provider.h View 1 1 chunk +26 lines, -0 lines 0 comments Download
A ios/chrome/browser/providers/signin/chromium_signin_resources_provider.mm View 1 1 chunk +27 lines, -0 lines 0 comments Download
A ios/chrome/browser/providers/ui/BUILD.gn View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/chrome/browser/providers/ui/chromium_styled_text_field.h View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/chrome/browser/providers/ui/chromium_styled_text_field.mm View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
rohitrao (ping after 24h)
More updates to get the app running and tests passing.
4 years ago (2016-11-26 23:31:26 UTC) #6
sdefresne
lgtm
4 years ago (2016-11-28 11:00:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529203002/20001
4 years ago (2016-11-28 12:35:13 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-28 14:07:59 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-28 14:09:34 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09fd6245fae38d10caa8cff99d777b95f22b909a
Cr-Commit-Position: refs/heads/master@{#434649}

Powered by Google App Engine
This is Rietveld 408576698