Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 252913002: Stopgap: Adding back AucocompleteController::input() accessor to unbreak clank. (Closed)

Created:
6 years, 7 months ago by beaudoin
Modified:
6 years, 7 months ago
CC:
chromium-reviews, James Su, Feng Qian
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Stopgap: Adding back AucocompleteController::input() accessor to unbreak clank. This is a temporary fix to unbreak clank while they remove their dependency on that method. BUG=367832 TBR=pkasting@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266592

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added bug id to comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/autocomplete/autocomplete_controller.h View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Feng Qian
lgtm https://codereview.chromium.org/252913002/diff/1/chrome/browser/autocomplete/autocomplete_controller.h File chrome/browser/autocomplete/autocomplete_controller.h (right): https://codereview.chromium.org/252913002/diff/1/chrome/browser/autocomplete/autocomplete_controller.h#newcode123 chrome/browser/autocomplete/autocomplete_controller.h:123: // TODO(beaudoin): Remove this method once clank no ...
6 years, 7 months ago (2014-04-28 17:05:30 UTC) #1
beaudoin
Landing this to unblock clank. https://codereview.chromium.org/252913002/diff/1/chrome/browser/autocomplete/autocomplete_controller.h File chrome/browser/autocomplete/autocomplete_controller.h (right): https://codereview.chromium.org/252913002/diff/1/chrome/browser/autocomplete/autocomplete_controller.h#newcode123 chrome/browser/autocomplete/autocomplete_controller.h:123: // TODO(beaudoin): Remove this ...
6 years, 7 months ago (2014-04-28 17:09:22 UTC) #2
beaudoin
The CQ bit was checked by beaudoin@chromium.org
6 years, 7 months ago (2014-04-28 17:09:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaudoin@chromium.org/252913002/20001
6 years, 7 months ago (2014-04-28 17:10:27 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 17:15:16 UTC) #5
Message was sent while issue was closed.
Change committed as 266592

Powered by Google App Engine
This is Rietveld 408576698