Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2529113002:
[heap] StaticNewSpaceVisitor: Add UNREACHABLE handlers for pre-tenured types (Closed)
|
Created:
4 years ago by Michael Lippautz Modified:
4 years ago CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, rmcilroy Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] StaticNewSpaceVisitor: Add UNREACHABLE handlers for pre-tenured types
BUG=
Committed: https://crrev.com/ecea1d1911c21eda905894698982f5ee23ecc020
Cr-Commit-Position: refs/heads/master@{#41289}
Patch Set 1 #Patch Set 2 : Adjust type #Patch Set 3 : Fix compilation #
Messages
Total messages: 23 (13 generated)
Description was changed from ========== [heap] StaticNewSpaceVisitor: Add UNREACHABLE handlers for pre-tenured types BUG= ========== to ========== [heap] StaticNewSpaceVisitor: Add UNREACHABLE handlers for pre-tenured types BUG= ==========
mlippautz@chromium.org changed reviewers: + hpayer@chromium.org
lgtm
The CQ bit was checked by mlippautz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/16826)
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org Link to the patchset: https://codereview.chromium.org/2529113002/#ps20001 (title: "Adjust type")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org Link to the patchset: https://codereview.chromium.org/2529113002/#ps40001 (title: "Fix compilation")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
+ross: fyi
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480086813501600,
"parent_rev": "832ce1491ad6522b9abf7692835bd5495181add4", "commit_rev":
"4bd4c68e3d47074c35bf74fb600e8291c35d36e3"}
Message was sent while issue was closed.
Description was changed from ========== [heap] StaticNewSpaceVisitor: Add UNREACHABLE handlers for pre-tenured types BUG= ========== to ========== [heap] StaticNewSpaceVisitor: Add UNREACHABLE handlers for pre-tenured types BUG= ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
rmcilroy@chromium.org changed reviewers: + rmcilroy@chromium.org
Message was sent while issue was closed.
Looks good from my point of view, thanks!
Message was sent while issue was closed.
Description was changed from ========== [heap] StaticNewSpaceVisitor: Add UNREACHABLE handlers for pre-tenured types BUG= ========== to ========== [heap] StaticNewSpaceVisitor: Add UNREACHABLE handlers for pre-tenured types BUG= Committed: https://crrev.com/ecea1d1911c21eda905894698982f5ee23ecc020 Cr-Commit-Position: refs/heads/master@{#41289} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/ecea1d1911c21eda905894698982f5ee23ecc020 Cr-Commit-Position: refs/heads/master@{#41289} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
