Add account_type into AccountId

components/signin/core/account_id/account_id.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SIGNIN_CORE_ACCOUNT_ID_ACCOUNT_ID_H_
 #define COMPONENTS_SIGNIN_CORE_ACCOUNT_ID_ACCOUNT_ID_H_
 
 #include <stddef.h>
 
 #include <string>
 #include "base/containers/hash_tables.h"
 
 // Type that contains enough information to identify user.
 //
 // TODO(alemate): we are in the process of moving away from std::string as a
 // type for storing user identifier to AccountId. At this time GaiaId is mostly
 // empty, so this type is used as a replacement for e-mail string.
 // But in near future AccountId will become full feature user identifier.
 class AccountId {
  public:
+  // Known account types.
+  static const std::string kGoogle;

[Andrew T Wilson (Slow), 2016/11/29 11:05:36]

Why are we defining account types as strings and not as an enum? It's less
type-safe this way (see my previous comment about passing a gaia_id as the
account type?)

[Roman Sorokin (ftl), 2016/12/02 11:13:11]

Switched to enum class AccountType

+  static const std::string kAd;
+
   struct EmptyAccountId;
 
   AccountId(const AccountId& other);
 
   bool operator==(const AccountId& other) const;
   bool operator!=(const AccountId& other) const;
   bool operator<(const AccountId& right) const;
 
   // empty() is deprecated. Use !is_valid() instead.
   bool empty() const;
   bool is_valid() const;
   void clear();
 
   const std::string& GetAccountType() const;
   const std::string& GetGaiaId() const;
   // Users of AccountId should make no assumptions on the format of email.
   // I.e. it cannot be used as account identifier, because it is (in general)
   // non-comparable.
   const std::string& GetUserEmail() const;
 
   // This returns prefixed some string that can be used as a storage key.
   // You should make no assumptions on the format of this string.
   const std::string GetAccountIdKey() const;
 
   void SetGaiaId(const std::string& gaia_id);
   void SetUserEmail(const std::string& email);
+  void SetAccountType(const std::string& account_type);
 
   // This method is to be used during transition period only.
   static AccountId FromUserEmail(const std::string& user_email);
   // This method is to be used during transition period only.
   static AccountId FromGaiaId(const std::string& gaia_id);
   // This method is the preferred way to construct AccountId if you have
   // full account information.
   static AccountId FromUserEmailGaiaId(const std::string& user_email,
                                        const std::string& gaia_id);
+  // This method is used to construct AccountId with specific types.
+  static AccountId FromUserEmailGaiaIdAccountType(
+      const std::string& email,
+      const std::string& gaia_id,
+      const std::string& account_type);
+  static AccountId FromGaiaIdAccountType(const std::string& gaia_id,
+                                         const std::string& account_type);
 
   // These are (for now) unstable and cannot be used to store serialized data to
   // persistent storage. Only in-memory storage is safe.
   // Serialize() returns JSON dictionary,
   // Deserialize() restores AccountId after serialization.
   std::string Serialize() const;
   static bool Deserialize(const std::string& serialized,
                           AccountId* out_account_id);
 
  private:
   AccountId();
   AccountId(const std::string& gaia_id, const std::string& user_email);
+  AccountId(const std::string& gaia_id,
+            const std::string& user_email,
+            const std::string& account_type);
 
   std::string gaia_id_;
   std::string user_email_;
+  std::string account_type_ = kGoogle;
 };
 
 // Returns a reference to a singleton.
 const AccountId& EmptyAccountId();
 
 namespace BASE_HASH_NAMESPACE {
 
 // Implement hashing of AccountId, so it can be used as a key in STL containers.
 template <>
 struct hash<AccountId> {
   std::size_t operator()(const AccountId& user_id) const;
 };
 
 }  // namespace BASE_HASH_NAMESPACE
 
 #endif  // COMPONENTS_SIGNIN_CORE_ACCOUNT_ID_ACCOUNT_ID_H_