Make extensions developer mode adhere to policy

chrome/browser/resources/extensions/extensions.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../../../../ui/webui/resources/js/cr/ui/focus_row.js">
 <include src="../../../../ui/webui/resources/js/cr/ui/focus_grid.js">
 <include src="../uber/uber_utils.js">
 <include src="drag_and_drop_handler.js">
 <include src="extension_code.js">
 <include src="extension_commands_overlay.js">
@@ skipping 178 matching lines @@
     update_: function(profileInfo) {
       // We only set the page to be loading if we haven't already finished an
       // initial load, because otherwise the updates are all incremental and
       // don't need to display the interstitial spinner.
       if (!this.hasLoaded_)
         this.setLoading_(true);
       webuiResponded = true;
 
       /** @const */
       var supervised = profileInfo.isSupervised;
+      var developerModeDisabledByPolicy = profileInfo.

[Bernhard Bauer, 2016/11/25 15:43:35]

Ugh. Can you break after the equals sign?

[pmarko, 2016/11/28 14:19:30]

Done.

+          isDeveloperModeDisabledByPolicy;
 
       var pageDiv = $('extension-settings');
       pageDiv.classList.toggle('profile-is-supervised', supervised);
       pageDiv.classList.toggle('showing-banner', supervised);
 
       var devControlsCheckbox = $('toggle-dev-on');
       devControlsCheckbox.checked = profileInfo.inDeveloperMode;
-      devControlsCheckbox.disabled = supervised;
+      devControlsCheckbox.disabled =
+          supervised || developerModeDisabledByPolicy;
+
+      // This is necessary e.g. if developer mode is now disabled by policy
+      // but extension developer tools were visible
+      this.updateDevControlsVisibility_(true);
+      this.setDevToggleControlledIndicator_(developerModeDisabledByPolicy);
 
       $('load-unpacked').disabled = !profileInfo.canLoadUnpacked;
       var extensionList = $('extension-settings-list');
       extensionList.updateExtensionsData(
           profileInfo.isIncognitoAvailable,
           profileInfo.appInfoDialogEnabled).then(function() {
         if (!this.hasLoaded_) {
           this.hasLoaded_ = true;
           this.setLoading_(false);
         }
         this.onExtensionCountChanged();
       }.bind(this));
     },
 
     /**
+     * Shows or hides the 'controlled by policy' indicator on the dev-toggle
+     * checkbox.
+     * @param {boolean} developerModeDisabledByPolicy true if the indicator
+     *     should be showing.
+     * @private
+     */
+    setDevToggleControlledIndicator_: function(developerModeDisabledByPolicy) {
+      var devToggleControlledIndicator = document.querySelector(
+          '#dev-toggle .controlled-setting-indicator');
+
+      if (!(devToggleControlledIndicator instanceof cr.ui.ControlledIndicator))
+        cr.ui.ControlledIndicator.decorate(devToggleControlledIndicator);
+
+      if (developerModeDisabledByPolicy) {
+        var controlledBy = 'policy';
+        devToggleControlledIndicator.setAttribute('controlled-by',
+            controlledBy);
+        devToggleControlledIndicator.setAttribute('text' + controlledBy,
+            loadTimeData.getString('controlledSettingPolicy'));
+      }
+      else

[Bernhard Bauer, 2016/11/25 15:43:35]

If the if-clause uses braces, so should the else.

[pmarko, 2016/11/28 14:19:30]

Done.

+        devToggleControlledIndicator.removeAttribute('controlled-by');
+    },
+
+    /**
      * Shows the loading spinner and hides elements that shouldn't be visible
      * while loading.
      * @param {boolean} isLoading
      * @private
      */
     setLoading_: function(isLoading) {
       document.documentElement.classList.toggle('loading', isLoading);
       $('loading-spinner').hidden = !isLoading;
       $('dev-controls').hidden = isLoading;
       this.updateDevControlsVisibility_(false);
@@ skipping 193 matching lines @@
 
   // Export
   return {
     ExtensionSettings: ExtensionSettings
   };
 });
 
 window.addEventListener('load', function(e) {
   extensions.ExtensionSettings.getInstance().initialize();
 });