third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/animation-direction.html - Issue 2529043002: [CSS Typed OM] Add a property test generator for testing the inline StylePropertyMap

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/animation-direction.html

Issue 2529043002: [CSS Typed OM] Add a property test generator for testing the inline StylePropertyMap (Closed)

Patch Set: Add expectation files Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/animation-direction-expected.txt » ('j') | third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/bottom-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src='../../../resources/testharness.js'></script>

	3 <script src='../../../resources/testharnessreport.js'></script>

	4 <script src='property-suite.js'></script>

	5

	6 <div id="testElement"></div>
	dstockwell 2016/11/29 06:26:35 The suite should just generate this element. The suite should just generate this element. meade_UTC10 2016/12/01 03:48:20 Done. Show quoted text On 2016/11/29 06:26:35, dstockwell wrote: > The suite should just generate this element. Done.
	7

	8 <script>

	9

	10 var config = {

	11 validKeywords: [

	12 'normal',

	13 'reverse',

	14 'alternate',

	15 'alternate-reverse',

	16 ],

	17 validObjects: [

	18 ],

	19 supportsMultiple: true,

	20 invalidObjects: [

	21 new CSSSimpleLength(4, 'px'),

	22 ]

	23 };

	24

	25 generatePropertySuite('animation-direction', config, testElement);
	dstockwell 2016/11/29 06:26:35 Simpler to just inline to config here. Calling th Simpler to just inline to config here. Calling this generate* is a bit weird too, since it actually runs the test. So maybe something like: testTypedOM('animation-direction', { ... dstockwell 2016/11/29 06:26:35 Simpler to just inline to config here and make the Simpler to just inline to config here and make the property part of it. meade_UTC10 2016/12/01 03:48:20 Done. Show quoted text On 2016/11/29 06:26:35, dstockwell wrote: > Simpler to just inline to config here. > > Calling this generate* is a bit weird too, since it actually runs the test. > > So maybe something like: > testTypedOM('animation-direction', { ... Done.
	26

	27 </script>

	28

OLD	NEW