Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 2529033002: binding: Makes Dictionary handle a possible exception in [[Get]]. (Closed)

Created:
4 years ago by Yuki
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

binding: Makes Dictionary handle a possible exception in [[Get]]. Dictionary retrieves a dictionary member through the [[Get]] internal method of the dictionary object. Since the properties can be accessor properties, arbitrary script may run in [[Get]], so we have to handle a possible exception in [[Get]]. The right fix is to propagate the exception up to the caller, however, there are so many callers and the issue is urgent. So simply swallowing all the exceptions in this CL, and fix it re-throws in a follow-up CL. BUG=644237 Review-Url: https://codereview.chromium.org/2496533002 Cr-Commit-Position: refs/heads/master@{#431848} (cherry picked from commit 5f971b7bafe1c9a8574e66525b593644e4b9d658) Committed: https://chromium.googlesource.com/chromium/src/+/f924a45a1c9276a2f145ece28b6d645839997981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -22 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/dictionary-member-get-throws.html View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp View 4 chunks +11 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/DictionaryIterator.cpp View 2 chunks +34 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Yuki
4 years ago (2016-11-25 06:08:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f924a45a1c9276a2f145ece28b6d645839997981.

Powered by Google App Engine
This is Rietveld 408576698