Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2529013003: Round the scroll offset synced back to main instead of flooring. (Closed)

Created:
4 years ago by flackr
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Round the scroll offset synced back to main instead of flooring. When scrolling up, flooring the scroll delta sent back to main can result in main thinking that we have scrolled up by a pixel while cc still positions layers as if we are at the old scroll position. To be technically correct according to the frame that will be produced, we would need to round according to the current scroll snap size but this isn ot easily known at the time of rounding so we use the nearest integer since this is the common case. BUG=663291 TEST=LayerTreeHostImplTest.SyncSubpixelScrollDelta CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2511473003 Cr-Commit-Position: refs/heads/master@{#434022} (cherry picked from commit 75a7e4cb1ec29ded2e52539259233356caa883c8) Committed: https://chromium.googlesource.com/chromium/src/+/ec4538615b56748d5cf39ce63ddefe40937211f9

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
flackr
4 years ago (2016-11-25 22:06:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ec4538615b56748d5cf39ce63ddefe40937211f9.

Powered by Google App Engine
This is Rietveld 408576698