Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2529013002: Nits in fx_ge_linux (Closed)

Created:
4 years ago by npm
Modified:
4 years ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Nits in fx_ge_linux Moved all CFX_LinuxFontInfo to the namespace. Added its constructor and destructor. And fixed includes and {}s. Committed: https://pdfium.googlesource.com/pdfium/+/80ddd61fa9bbb76cbebaa0c28fb166ae7a75a828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -36 lines) Patch
M core/fxge/ge/fx_ge_linux.cpp View 5 chunks +30 lines, -36 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
npm
PTAL
4 years ago (2016-11-24 23:57:15 UTC) #3
Lei Zhang
lgtm
4 years ago (2016-11-28 18:19:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529013002/1
4 years ago (2016-11-28 19:13:00 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-28 19:27:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/80ddd61fa9bbb76cbebaa0c28fb166ae7a75...

Powered by Google App Engine
This is Rietveld 408576698