Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2528983002: Makes ui:window_manager include most client interfaces (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
Reviewers:
Tom Sepez, sadrul
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes ui:window_manager include most client interfaces Just as with the client group the window_manager group should include most of the client interfaces. BUG=none TEST=none R=sadrul@chromium.org, tsepez@chromium.org Committed: https://crrev.com/373d348b19fed0378623a39f7ef5325c2407e61f Cr-Commit-Position: refs/heads/master@{#434721}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M services/ui/manifest.json View 2 chunks +9 lines, -0 lines 2 comments Download
M services/ui/test_wm/manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
sky
4 years ago (2016-11-24 17:11:28 UTC) #1
sadrul
lgtm https://codereview.chromium.org/2528983002/diff/1/services/ui/manifest.json File services/ui/manifest.json (right): https://codereview.chromium.org/2528983002/diff/1/services/ui/manifest.json#newcode10 services/ui/manifest.json:10: // to ui:window_manager as well. It'd be nice ...
4 years ago (2016-11-25 18:42:09 UTC) #6
sky
https://codereview.chromium.org/2528983002/diff/1/services/ui/manifest.json File services/ui/manifest.json (right): https://codereview.chromium.org/2528983002/diff/1/services/ui/manifest.json#newcode10 services/ui/manifest.json:10: // to ui:window_manager as well. On 2016/11/25 18:42:09, sadrul ...
4 years ago (2016-11-28 15:53:36 UTC) #7
Tom Sepez
lgtm
4 years ago (2016-11-28 17:31:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2528983002/1
4 years ago (2016-11-28 17:38:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 21:19:02 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-28 21:21:35 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/373d348b19fed0378623a39f7ef5325c2407e61f
Cr-Commit-Position: refs/heads/master@{#434721}

Powered by Google App Engine
This is Rietveld 408576698