Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc

Issue 2528963002: [scheduler] Fix TaskQueueThrottler::SetQueueEnabled logic. (Closed)
Patch Set: Rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
index fa5e09bf510c4b1892f563c9f9399d4a3772d6a4..5717f6b2a6b802704cfd1b9209ebc703d9235241 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
@@ -1052,5 +1052,28 @@ TEST_F(TaskQueueThrottlerTest, AddQueueToBudgetPoolWhenThrottlingDisabled) {
base::TimeDelta::FromMilliseconds(300)));
}
+TEST_F(TaskQueueThrottlerTest,
+ TaskQueueThrottledAndDisabledTillPump_ThenManuallyEnabled) {
+ size_t count = 0;
+ timer_queue_->PostTask(FROM_HERE, base::Bind(&AddOneTask, &count));
+
+ EXPECT_TRUE(timer_queue_->IsQueueEnabled());
+ task_queue_throttler_->IncreaseThrottleRefCount(timer_queue_.get());
+ EXPECT_FALSE(timer_queue_->IsQueueEnabled());
+
+ task_queue_throttler_->SetQueueEnabled(timer_queue_.get(), false);
+ EXPECT_FALSE(timer_queue_->IsQueueEnabled());
+
+ mock_task_runner_->RunUntilIdle();
+ EXPECT_EQ(0u, count);
+
+ task_queue_throttler_->SetQueueEnabled(timer_queue_.get(), true);
+ EXPECT_FALSE(timer_queue_->IsQueueEnabled());
+
+ mock_task_runner_->RunUntilIdle(); // Wait until the pump.
+ EXPECT_EQ(1u, count); // Task ran
+ EXPECT_TRUE(timer_queue_->IsQueueEnabled());
+}
+
} // namespace scheduler
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698