Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

Issue 2528963002: [scheduler] Fix TaskQueueThrottler::SetQueueEnabled logic. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
index 0ebf0ab05dbc9b287384c6ef5b41bd3683e7e720..5c9fc41815c06af0e9743e4c9ce35bccf6240ca4 100644
--- a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
+++ b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
@@ -8,7 +8,9 @@
#include <set>
#include "base/bind.h"
+#include "base/format_macros.h"
#include "base/metrics/histogram_macros.h"
+#include "base/strings/stringprintf.h"
#include "base/trace_event/trace_event.h"
#include "platform/scheduler/base/real_time_domain.h"
#include "platform/scheduler/base/task_queue_impl.h"
@@ -48,8 +50,14 @@ base::RepeatingClosure UnsafeConvertOnceClosureToRepeating(
return base::BindRepeating([](base::OnceClosure cb) { std::move(cb).Run(); },
base::Passed(&cb));
}
+
+std::string PointerToId(void* pointer) {
alex clarke (OOO till 29th) 2016/11/24 14:45:07 Can we land this separately? It seems unrelated t
altimin 2016/11/24 15:00:55 Oops, sorry.
+ return base::StringPrintf(
+ "%" PRIx64, static_cast<uint64_t>(reinterpret_cast<uintptr_t>(pointer)));
}
+} // namespace
+
TaskQueueManager::TaskQueueManager(
scoped_refptr<TaskQueueManagerDelegate> delegate,
const char* tracing_category,
@@ -347,8 +355,8 @@ TaskQueueManager::ProcessTaskResult TaskQueueManager::ProcessTaskFromWorkQueue(
observer.WillProcessTask(pending_task);
queue->NotifyWillProcessTask(pending_task);
}
- TRACE_EVENT1(tracing_category_, "TaskQueueManager::RunTask", "queue",
- queue->GetName());
+ TRACE_EVENT2(tracing_category_, "TaskQueueManager::RunTask", "queue",
+ queue->GetName(), "queue_id", PointerToId(queue));
// NOTE when TaskQueues get unregistered a reference ends up getting retained
// by |queues_to_delete_| which is cleared at the top of |DoWork|. This means
// we are OK to use raw pointers here.

Powered by Google App Engine
This is Rietveld 408576698