Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: src/heap/heap-inl.h

Issue 2528943002: Revert of [heap] Use store buffer for writes coming from mutator. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | src/heap/store-buffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap-inl.h
diff --git a/src/heap/heap-inl.h b/src/heap/heap-inl.h
index 90d19280398d1d312d5ce9a6f9f1905fa62b38bd..c3fa55aed9b2eacd2b28af34f905b101d9f38983 100644
--- a/src/heap/heap-inl.h
+++ b/src/heap/heap-inl.h
@@ -502,7 +502,9 @@
if (!InNewSpace(o) || !object->IsHeapObject() || InNewSpace(object)) {
return;
}
- store_buffer()->InsertEntry(HeapObject::cast(object)->address() + offset);
+ RememberedSet<OLD_TO_NEW>::Insert(
+ Page::FromAddress(reinterpret_cast<Address>(object)),
+ HeapObject::cast(object)->address() + offset);
}
void Heap::RecordWriteIntoCode(Code* host, RelocInfo* rinfo, Object* value) {
@@ -513,9 +515,11 @@
void Heap::RecordFixedArrayElements(FixedArray* array, int offset, int length) {
if (InNewSpace(array)) return;
+ Page* page = Page::FromAddress(reinterpret_cast<Address>(array));
for (int i = 0; i < length; i++) {
if (!InNewSpace(array->get(offset + i))) continue;
- store_buffer()->InsertEntry(
+ RememberedSet<OLD_TO_NEW>::Insert(
+ page,
reinterpret_cast<Address>(array->RawFieldOfElementAt(offset + i)));
}
}
« no previous file with comments | « src/heap/heap.cc ('k') | src/heap/store-buffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698