Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Side by Side Diff: src/heap/store-buffer.h

Issue 2528943002: Revert of [heap] Use store buffer for writes coming from mutator. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/heap-inl.h ('k') | src/heap/store-buffer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_STORE_BUFFER_H_ 5 #ifndef V8_STORE_BUFFER_H_
6 #define V8_STORE_BUFFER_H_ 6 #define V8_STORE_BUFFER_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/base/logging.h" 9 #include "src/base/logging.h"
10 #include "src/base/platform/platform.h" 10 #include "src/base/platform/platform.h"
11 #include "src/cancelable-task.h" 11 #include "src/cancelable-task.h"
12 #include "src/globals.h" 12 #include "src/globals.h"
13 #include "src/heap/remembered-set.h"
14 #include "src/heap/slot-set.h" 13 #include "src/heap/slot-set.h"
15 14
16 namespace v8 { 15 namespace v8 {
17 namespace internal { 16 namespace internal {
18 17
19 // Intermediate buffer that accumulates old-to-new stores from the generated 18 // Intermediate buffer that accumulates old-to-new stores from the generated
20 // code. Moreover, it stores invalid old-to-new slots with two entries. 19 // code. Moreover, it stores invalid old-to-new slots with two entries.
21 // The first is a tagged address of the start of the invalid range, the second 20 // The first is a tagged address of the start of the invalid range, the second
22 // one is the end address of the invalid range or null if there is just one slot 21 // one is the end address of the invalid range or null if there is just one slot
23 // that needs to be removed from the remembered set. On buffer overflow the 22 // that needs to be removed from the remembered set. On buffer overflow the
24 // slots are moved to the remembered set. 23 // slots are moved to the remembered set.
25 class StoreBuffer { 24 class StoreBuffer {
26 public: 25 public:
27 static const int kStoreBufferSize = 1 << (14 + kPointerSizeLog2); 26 static const int kStoreBufferSize = 1 << (14 + kPointerSizeLog2);
28 static const int kStoreBufferMask = kStoreBufferSize - 1; 27 static const int kStoreBufferMask = kStoreBufferSize - 1;
29 static const int kStoreBuffers = 2; 28 static const int kStoreBuffers = 2;
30 static const intptr_t kDeletionTag = 1; 29 static const intptr_t kDeletionTag = 1;
31 30
32 V8_EXPORT_PRIVATE static void StoreBufferOverflow(Isolate* isolate); 31 static void StoreBufferOverflow(Isolate* isolate);
33 32
34 explicit StoreBuffer(Heap* heap); 33 explicit StoreBuffer(Heap* heap);
35 void SetUp(); 34 void SetUp();
36 void TearDown(); 35 void TearDown();
37 36
38 // Used to add entries from generated code. 37 // Used to add entries from generated code.
39 inline Address* top_address() { return reinterpret_cast<Address*>(&top_); } 38 inline Address* top_address() { return reinterpret_cast<Address*>(&top_); }
40 39
41 // Moves entries from a specific store buffer to the remembered set. This 40 // Moves entries from a specific store buffer to the remembered set. This
42 // method takes a lock. 41 // method takes a lock.
(...skipping 15 matching lines...) Expand all
58 inline Address UnmarkDeletionAddress(Address address) { 57 inline Address UnmarkDeletionAddress(Address address) {
59 return reinterpret_cast<Address>(reinterpret_cast<intptr_t>(address) & 58 return reinterpret_cast<Address>(reinterpret_cast<intptr_t>(address) &
60 ~kDeletionTag); 59 ~kDeletionTag);
61 } 60 }
62 61
63 // If we only want to delete a single slot, end should be set to null which 62 // If we only want to delete a single slot, end should be set to null which
64 // will be written into the second field. When processing the store buffer 63 // will be written into the second field. When processing the store buffer
65 // the more efficient Remove method will be called in this case. 64 // the more efficient Remove method will be called in this case.
66 void DeleteEntry(Address start, Address end = nullptr); 65 void DeleteEntry(Address start, Address end = nullptr);
67 66
68 void InsertEntry(Address slot) {
69 // Insertions coming from the GC are directly inserted into the remembered
70 // set. Insertions coming from the runtime are added to the store buffer to
71 // allow concurrent processing.
72 if (heap_->gc_state() == Heap::NOT_IN_GC) {
73 if (top_ + sizeof(Address) > limit_[current_]) {
74 StoreBufferOverflow(heap_->isolate());
75 }
76 *top_ = slot;
77 top_++;
78 } else {
79 // In GC the store buffer has to be empty at any time.
80 DCHECK(Empty());
81 RememberedSet<OLD_TO_NEW>::Insert(Page::FromAddress(slot), slot);
82 }
83 }
84
85 // Used by the concurrent processing thread to transfer entries from the 67 // Used by the concurrent processing thread to transfer entries from the
86 // store buffer to the remembered set. 68 // store buffer to the remembered set.
87 void ConcurrentlyProcessStoreBuffer(); 69 void ConcurrentlyProcessStoreBuffer();
88 70
89 bool Empty() { 71 bool Empty() {
90 for (int i = 0; i < kStoreBuffers; i++) { 72 for (int i = 0; i < kStoreBuffers; i++) {
91 if (lazy_top_[i]) { 73 if (lazy_top_[i]) {
92 return false; 74 return false;
93 } 75 }
94 } 76 }
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 // Points to the current buffer in use. 124 // Points to the current buffer in use.
143 int current_; 125 int current_;
144 126
145 base::VirtualMemory* virtual_memory_; 127 base::VirtualMemory* virtual_memory_;
146 }; 128 };
147 129
148 } // namespace internal 130 } // namespace internal
149 } // namespace v8 131 } // namespace v8
150 132
151 #endif // V8_STORE_BUFFER_H_ 133 #endif // V8_STORE_BUFFER_H_
OLDNEW
« no previous file with comments | « src/heap/heap-inl.h ('k') | src/heap/store-buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698